From: Arnd Bergmann <arnd@arndb.de>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Peter Griffin <peter.griffin@linaro.org>,
linux-kernel@vger.kernel.org, linaro-kernel@lists.linaro.org,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
linux-fbdev@vger.kernel.org, Anatolij Gustschin <agust@denx.de>
Subject: Re: [PATCH 03/13] video: clarify I2C dependencies
Date: Thu, 24 Apr 2014 12:48:26 +0000 [thread overview]
Message-ID: <12886728.o7TzRXlxjF@wuerfel> (raw)
In-Reply-To: <20140424123235.GS26756@n2100.arm.linux.org.uk>
On Thursday 24 April 2014 13:32:35 Russell King - ARM Linux wrote:
> On Thu, Apr 24, 2014 at 01:28:19PM +0100, Peter Griffin wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > We can only use I2C support in frame buffer drivers if
> > Either I2C is built-in, or both I2C and the driver itself
> > are loadable modules.
>
> Why?
If I2C is a loadable module, and the I2C support of the framebuffer
driver is built-in, you get a link error when building vmlinux:
drivers/built-in.o: In function `cyberpro_pci_remove':
:(.text+0x1ea5c): undefined reference to `i2c_del_adapter'
drivers/built-in.o: In function `cyberpro_pci_probe':
:(.text+0x20224): undefined reference to `i2c_bit_add_bus'
:(.text+0x20240): undefined reference to `i2c_del_adapter'
make[2]: *** [vmlinux] Error 1
It's probably a good idea to mention that in the changeset
text.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Peter Griffin <peter.griffin@linaro.org>,
linux-kernel@vger.kernel.org, linaro-kernel@lists.linaro.org,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
linux-fbdev@vger.kernel.org, Anatolij Gustschin <agust@denx.de>
Subject: Re: [PATCH 03/13] video: clarify I2C dependencies
Date: Thu, 24 Apr 2014 14:48:26 +0200 [thread overview]
Message-ID: <12886728.o7TzRXlxjF@wuerfel> (raw)
In-Reply-To: <20140424123235.GS26756@n2100.arm.linux.org.uk>
On Thursday 24 April 2014 13:32:35 Russell King - ARM Linux wrote:
> On Thu, Apr 24, 2014 at 01:28:19PM +0100, Peter Griffin wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > We can only use I2C support in frame buffer drivers if
> > Either I2C is built-in, or both I2C and the driver itself
> > are loadable modules.
>
> Why?
If I2C is a loadable module, and the I2C support of the framebuffer
driver is built-in, you get a link error when building vmlinux:
drivers/built-in.o: In function `cyberpro_pci_remove':
:(.text+0x1ea5c): undefined reference to `i2c_del_adapter'
drivers/built-in.o: In function `cyberpro_pci_probe':
:(.text+0x20224): undefined reference to `i2c_bit_add_bus'
:(.text+0x20240): undefined reference to `i2c_del_adapter'
make[2]: *** [vmlinux] Error 1
It's probably a good idea to mention that in the changeset
text.
Arnd
next prev parent reply other threads:[~2014-04-24 12:48 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 12:28 [PATCH 00/13] video: Arnds randconfig fixes for video Peter Griffin
2014-04-24 12:28 ` [PATCH 01/13] video: sh_mobile_lcdcfb depends on meram Peter Griffin
2014-04-24 12:28 ` Peter Griffin
2014-04-24 12:28 ` [PATCH 02/13] video: omap2dss: fix LPAE warnings Peter Griffin
2014-04-24 12:28 ` Peter Griffin
2014-04-24 12:28 ` [PATCH 03/13] video: clarify I2C dependencies Peter Griffin
2014-04-24 12:28 ` Peter Griffin
2014-04-24 12:32 ` Russell King - ARM Linux
2014-04-24 12:32 ` Russell King - ARM Linux
2014-04-24 12:48 ` Arnd Bergmann [this message]
2014-04-24 12:48 ` Arnd Bergmann
2014-04-24 12:28 ` [PATCH 04/13] video/omap: fix modular build Peter Griffin
2014-04-24 12:28 ` Peter Griffin
2014-04-24 12:28 ` [PATCH 05/13] video/mbx: fix building debugfs support Peter Griffin
2014-04-24 12:28 ` Peter Griffin
2014-04-24 12:28 ` [PATCH 06/13] video: export fb_prepare_logo Peter Griffin
2014-04-24 12:28 ` Peter Griffin
2014-04-24 12:28 ` [PATCH 07/13] video: atmel needs FB_BACKLIGHT Peter Griffin
2014-04-24 12:28 ` Peter Griffin
2014-04-24 12:28 ` [PATCH 08/13] video/backlight: LM3630A needs PWM Peter Griffin
2014-04-24 12:28 ` Peter Griffin
2014-04-24 16:45 ` Bryan Wu
2014-04-24 16:45 ` Bryan Wu
2014-04-25 9:00 ` Jingoo Han
2014-04-25 9:00 ` Jingoo Han
2014-04-28 10:14 ` Lee Jones
2014-04-28 10:14 ` Lee Jones
2014-04-24 12:28 ` [PATCH 09/13] video/backlight: LP8788 " Peter Griffin
2014-04-24 12:28 ` Peter Griffin
2014-04-24 16:45 ` Bryan Wu
2014-04-24 16:45 ` Bryan Wu
2014-04-24 22:42 ` Milo Kim
2014-04-24 22:42 ` Milo Kim
2014-04-25 8:54 ` Jingoo Han
2014-04-25 8:54 ` Jingoo Han
2014-04-28 10:16 ` Lee Jones
2014-04-28 10:16 ` Lee Jones
2014-04-24 12:28 ` [PATCH 10/13] video/pxa: LCD_CORGI needs BACKLIGHT_CLASS_DEVICE Peter Griffin
2014-04-24 12:28 ` Peter Griffin
2014-04-24 16:46 ` Bryan Wu
2014-04-24 16:46 ` Bryan Wu
2014-04-25 8:58 ` Jingoo Han
2014-04-25 8:58 ` Jingoo Han
2014-04-28 10:15 ` Lee Jones
2014-04-28 10:15 ` Lee Jones
2014-04-24 12:28 ` [PATCH 11/13] video/nuc900: allow modular build Peter Griffin
2014-04-24 12:28 ` Peter Griffin
2014-04-24 12:28 ` [PATCH 12/13] video/backlight: LP855X needs PWM Peter Griffin
2014-04-24 12:28 ` Peter Griffin
2014-04-24 16:48 ` Bryan Wu
2014-04-24 16:48 ` Bryan Wu
2014-04-24 22:43 ` Milo Kim
2014-04-24 22:43 ` Milo Kim
2014-04-25 9:02 ` Jingoo Han
2014-04-25 9:02 ` Jingoo Han
2014-04-28 10:16 ` Lee Jones
2014-04-28 10:16 ` Lee Jones
2014-04-24 12:28 ` [PATCH 13/13] video: omap: allow building on !MMU Peter Griffin
2014-04-24 12:28 ` Peter Griffin
2014-05-07 9:14 ` Tomi Valkeinen
2014-05-07 9:14 ` Tomi Valkeinen
2014-05-07 9:14 ` Tomi Valkeinen
2014-05-08 21:53 ` Tony Lindgren
2014-05-08 21:53 ` Tony Lindgren
2014-05-08 23:04 ` Aaro Koskinen
2014-05-08 23:04 ` Aaro Koskinen
2014-05-08 23:17 ` Tony Lindgren
2014-05-08 23:17 ` Tony Lindgren
2014-05-09 21:21 ` Aaro Koskinen
2014-05-09 21:21 ` Aaro Koskinen
2014-05-11 15:01 ` Tony Lindgren
2014-05-11 15:01 ` Tony Lindgren
2014-05-07 9:18 ` [PATCH 00/13] video: Arnds randconfig fixes for video Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12886728.o7TzRXlxjF@wuerfel \
--to=arnd@arndb.de \
--cc=agust@denx.de \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=peter.griffin@linaro.org \
--cc=plagnioj@jcrosoft.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.