All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alberto Panizzo <maramaopercheseimorto@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "Liam Girdwood" <lrg@slimlogic.co.uk>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	linux-kernel@vger.kernel.org,
	patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] regulator: Staticise mc13783_powermisc_rmw()
Date: Wed, 03 Nov 2010 14:50:08 +0100	[thread overview]
Message-ID: <1288792208.3311.96.camel@realization> (raw)
In-Reply-To: <1288757284-15812-1-git-send-email-broonie@opensource.wolfsonmicro.com>

On mer, 2010-11-03 at 00:08 -0400, Mark Brown wrote:
> It is not used outside this driver so no need to make the symbol global.
> 
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

It's OK for me, because no other functionalities than regulator's one
are influenced by the Power Misc register.

Acked-by: Alberto Panizzo <maramaopercheseimorto@gmail.com>

> ---
>  drivers/regulator/mc13783-regulator.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/regulator/mc13783-regulator.c b/drivers/regulator/mc13783-regulator.c
> index 5e6fa47..47ea999 100644
> --- a/drivers/regulator/mc13783-regulator.c
> +++ b/drivers/regulator/mc13783-regulator.c
> @@ -471,8 +471,8 @@ static struct regulator_ops mc13783_fixed_regulator_ops = {
>  	.get_voltage = mc13783_fixed_regulator_get_voltage,
>  };
>  
> -int mc13783_powermisc_rmw(struct mc13783_regulator_priv *priv, u32 mask,
> -									u32 val)
> +static int mc13783_powermisc_rmw(struct mc13783_regulator_priv *priv, u32 mask,
> +				 u32 val)
>  {
>  	struct mc13783 *mc13783 = priv->mc13783;
>  	int ret;


-- 
Alberto!

        Be Persistent!
                - Greg Kroah-Hartman (FOSDEM 2010)


  reply	other threads:[~2010-11-03 13:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-03  4:08 [PATCH] regulator: Staticise mc13783_powermisc_rmw() Mark Brown
2010-11-03 13:50 ` Alberto Panizzo [this message]
2010-11-03 14:16 ` Liam Girdwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1288792208.3311.96.camel@realization \
    --to=maramaopercheseimorto@gmail.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@slimlogic.co.uk \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=s.hauer@pengutronix.de \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.