* [PATCH] regulator: Staticise mc13783_powermisc_rmw()
@ 2010-11-03 4:08 Mark Brown
2010-11-03 13:50 ` Alberto Panizzo
2010-11-03 14:16 ` Liam Girdwood
0 siblings, 2 replies; 3+ messages in thread
From: Mark Brown @ 2010-11-03 4:08 UTC (permalink / raw)
To: Liam Girdwood, Sascha Hauer, Uwe Kleine-König
Cc: linux-kernel, patches, Mark Brown
It is not used outside this driver so no need to make the symbol global.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
drivers/regulator/mc13783-regulator.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/mc13783-regulator.c b/drivers/regulator/mc13783-regulator.c
index 5e6fa47..47ea999 100644
--- a/drivers/regulator/mc13783-regulator.c
+++ b/drivers/regulator/mc13783-regulator.c
@@ -471,8 +471,8 @@ static struct regulator_ops mc13783_fixed_regulator_ops = {
.get_voltage = mc13783_fixed_regulator_get_voltage,
};
-int mc13783_powermisc_rmw(struct mc13783_regulator_priv *priv, u32 mask,
- u32 val)
+static int mc13783_powermisc_rmw(struct mc13783_regulator_priv *priv, u32 mask,
+ u32 val)
{
struct mc13783 *mc13783 = priv->mc13783;
int ret;
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] regulator: Staticise mc13783_powermisc_rmw()
2010-11-03 4:08 [PATCH] regulator: Staticise mc13783_powermisc_rmw() Mark Brown
@ 2010-11-03 13:50 ` Alberto Panizzo
2010-11-03 14:16 ` Liam Girdwood
1 sibling, 0 replies; 3+ messages in thread
From: Alberto Panizzo @ 2010-11-03 13:50 UTC (permalink / raw)
To: Mark Brown
Cc: Liam Girdwood, Sascha Hauer, Uwe Kleine-König, linux-kernel,
patches
On mer, 2010-11-03 at 00:08 -0400, Mark Brown wrote:
> It is not used outside this driver so no need to make the symbol global.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
It's OK for me, because no other functionalities than regulator's one
are influenced by the Power Misc register.
Acked-by: Alberto Panizzo <maramaopercheseimorto@gmail.com>
> ---
> drivers/regulator/mc13783-regulator.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/regulator/mc13783-regulator.c b/drivers/regulator/mc13783-regulator.c
> index 5e6fa47..47ea999 100644
> --- a/drivers/regulator/mc13783-regulator.c
> +++ b/drivers/regulator/mc13783-regulator.c
> @@ -471,8 +471,8 @@ static struct regulator_ops mc13783_fixed_regulator_ops = {
> .get_voltage = mc13783_fixed_regulator_get_voltage,
> };
>
> -int mc13783_powermisc_rmw(struct mc13783_regulator_priv *priv, u32 mask,
> - u32 val)
> +static int mc13783_powermisc_rmw(struct mc13783_regulator_priv *priv, u32 mask,
> + u32 val)
> {
> struct mc13783 *mc13783 = priv->mc13783;
> int ret;
--
Alberto!
Be Persistent!
- Greg Kroah-Hartman (FOSDEM 2010)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] regulator: Staticise mc13783_powermisc_rmw()
2010-11-03 4:08 [PATCH] regulator: Staticise mc13783_powermisc_rmw() Mark Brown
2010-11-03 13:50 ` Alberto Panizzo
@ 2010-11-03 14:16 ` Liam Girdwood
1 sibling, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2010-11-03 14:16 UTC (permalink / raw)
To: Mark Brown; +Cc: Sascha Hauer, Uwe Kleine-König, linux-kernel, patches
On Wed, 2010-11-03 at 00:08 -0400, Mark Brown wrote:
> It is not used outside this driver so no need to make the symbol global.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> drivers/regulator/mc13783-regulator.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
Applied.
Thanks
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-11-03 14:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-03 4:08 [PATCH] regulator: Staticise mc13783_powermisc_rmw() Mark Brown
2010-11-03 13:50 ` Alberto Panizzo
2010-11-03 14:16 ` Liam Girdwood
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.