All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jiri Kosina <jkosina@suse.cz>
Cc: matt mooney <mfm@muteddisk.com>,
	linuxppc-dev@lists.ozlabs.org, kernel-janitors@vger.kernel.org,
	Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 2/3 RESEND] powerpc: remove cast from void*
Date: Wed, 03 Nov 2010 14:18:01 +0000	[thread overview]
Message-ID: <1288793881.2147.73.camel@pasglop> (raw)
In-Reply-To: <alpine.LNX.2.00.1011031015150.15851@pobox.suse.cz>

On Wed, 2010-11-03 at 10:15 -0400, Jiri Kosina wrote:
> On Mon, 27 Sep 2010, matt mooney wrote:
> 
> > Unnecessary cast from void* in assignment.
> > 
> > Signed-off-by: matt mooney <mfm@muteddisk.com>
> > ---
> >  arch/powerpc/platforms/pseries/hvCall_inst.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/arch/powerpc/platforms/pseries/hvCall_inst.c b/arch/powerpc/platforms/pseries/hvCall_inst.c
> > index e19ff02..f106662 100644
> > --- a/arch/powerpc/platforms/pseries/hvCall_inst.c
> > +++ b/arch/powerpc/platforms/pseries/hvCall_inst.c
> > @@ -55,7 +55,7 @@ static void hc_stop(struct seq_file *m, void *p)
> >  static int hc_show(struct seq_file *m, void *p)
> >  {
> >  	unsigned long h_num = (unsigned long)p;
> > -	struct hcall_stats *hs = (struct hcall_stats *)m->private;
> > +	struct hcall_stats *hs = m->private;
> >  
> >  	if (hs[h_num].num_calls) {
> >  		if (cpu_has_feature(CPU_FTR_PURR))
> 
> This doesn't seem to be present in 37-rc1, so I am taking it to trivial 
> queue. If this has been already merged to another tree, let me know.

Looks like I missed it, but Ack.

Cheers,
Ben.



WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jiri Kosina <jkosina@suse.cz>
Cc: matt mooney <mfm@muteddisk.com>,
	linuxppc-dev@lists.ozlabs.org, kernel-janitors@vger.kernel.org,
	Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 2/3 RESEND] powerpc: remove cast from void*
Date: Thu, 04 Nov 2010 01:18:01 +1100	[thread overview]
Message-ID: <1288793881.2147.73.camel@pasglop> (raw)
In-Reply-To: <alpine.LNX.2.00.1011031015150.15851@pobox.suse.cz>

On Wed, 2010-11-03 at 10:15 -0400, Jiri Kosina wrote:
> On Mon, 27 Sep 2010, matt mooney wrote:
> 
> > Unnecessary cast from void* in assignment.
> > 
> > Signed-off-by: matt mooney <mfm@muteddisk.com>
> > ---
> >  arch/powerpc/platforms/pseries/hvCall_inst.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/arch/powerpc/platforms/pseries/hvCall_inst.c b/arch/powerpc/platforms/pseries/hvCall_inst.c
> > index e19ff02..f106662 100644
> > --- a/arch/powerpc/platforms/pseries/hvCall_inst.c
> > +++ b/arch/powerpc/platforms/pseries/hvCall_inst.c
> > @@ -55,7 +55,7 @@ static void hc_stop(struct seq_file *m, void *p)
> >  static int hc_show(struct seq_file *m, void *p)
> >  {
> >  	unsigned long h_num = (unsigned long)p;
> > -	struct hcall_stats *hs = (struct hcall_stats *)m->private;
> > +	struct hcall_stats *hs = m->private;
> >  
> >  	if (hs[h_num].num_calls) {
> >  		if (cpu_has_feature(CPU_FTR_PURR))
> 
> This doesn't seem to be present in 37-rc1, so I am taking it to trivial 
> queue. If this has been already merged to another tree, let me know.

Looks like I missed it, but Ack.

Cheers,
Ben.

  reply	other threads:[~2010-11-03 14:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-28  2:04 [PATCH 0/3] remove cast from void* matt mooney
2010-09-28  2:04 ` [PATCH 1/3 RESEND] arm: " matt mooney
2010-09-28  2:04   ` matt mooney
2010-09-28  2:04   ` matt mooney
2010-09-28 16:55   ` Tony Lindgren
2010-09-28 16:55     ` Tony Lindgren
2010-09-28 16:55     ` Tony Lindgren
2010-09-28  2:04 ` [PATCH 2/3 RESEND] powerpc: " matt mooney
2010-09-28  2:04   ` matt mooney
2010-11-03 14:15   ` Jiri Kosina
2010-11-03 14:15     ` Jiri Kosina
2010-11-03 14:18     ` Benjamin Herrenschmidt [this message]
2010-11-03 14:18       ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1288793881.2147.73.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=jkosina@suse.cz \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mfm@muteddisk.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.