All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: David Brown <davidb@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org,
	"Daniel Walker" <dwalker@codeaurora.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	"Brian Swetland" <swetland@google.com>,
	"Arve Hjønnevåg" <arve@android.com>
Subject: Re: [PATCH v2] msm: smd: Reduce driver log chatter
Date: Tue, 09 Nov 2010 16:56:29 -0800	[thread overview]
Message-ID: <1289350589.28590.74.camel@Joe-Laptop> (raw)
In-Reply-To: <1289350168-20034-1-git-send-email-davidb@codeaurora.org>

On Tue, 2010-11-09 at 16:49 -0800, David Brown wrote:
> The MSM smd driver logs numerous messages during startup that are
> useful for debug purposes.  Change these to pr_debug() to match their
> purpose.
> diff --git a/arch/arm/mach-msm/smd.c b/arch/arm/mach-msm/smd.c
[]
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

If you add this, you probably want to strip
a few prefixes from the formats.

> +
>  #include <linux/platform_device.h>
>  #include <linux/module.h>
>  #include <linux/fs.h>
> @@ -89,7 +91,7 @@ static void smd_diag(void)
[]
> -		pr_info("smem: DIAG '%s'\n", x);
> +		pr_debug("smem: DIAG '%s'\n", x);

probably just
		pr_debug("DIAG '%s'\n", x);

>  	}
>  }
>  
> @@ -312,7 +314,7 @@ static void smd_state_change(struct smd_channel *ch,
[]
> -	pr_info("SMD: ch %d %d -> %d\n", ch->n, last, next);
> +	pr_debug("SMD: ch %d %d -> %d\n", ch->n, last, next);

	pr_debug("ch %d %d -> %d\n", ch->n, last, next);



WARNING: multiple messages have this Message-ID (diff)
From: joe@perches.com (Joe Perches)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] msm: smd: Reduce driver log chatter
Date: Tue, 09 Nov 2010 16:56:29 -0800	[thread overview]
Message-ID: <1289350589.28590.74.camel@Joe-Laptop> (raw)
In-Reply-To: <1289350168-20034-1-git-send-email-davidb@codeaurora.org>

On Tue, 2010-11-09 at 16:49 -0800, David Brown wrote:
> The MSM smd driver logs numerous messages during startup that are
> useful for debug purposes.  Change these to pr_debug() to match their
> purpose.
> diff --git a/arch/arm/mach-msm/smd.c b/arch/arm/mach-msm/smd.c
[]
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

If you add this, you probably want to strip
a few prefixes from the formats.

> +
>  #include <linux/platform_device.h>
>  #include <linux/module.h>
>  #include <linux/fs.h>
> @@ -89,7 +91,7 @@ static void smd_diag(void)
[]
> -		pr_info("smem: DIAG '%s'\n", x);
> +		pr_debug("smem: DIAG '%s'\n", x);

probably just
		pr_debug("DIAG '%s'\n", x);

>  	}
>  }
>  
> @@ -312,7 +314,7 @@ static void smd_state_change(struct smd_channel *ch,
[]
> -	pr_info("SMD: ch %d %d -> %d\n", ch->n, last, next);
> +	pr_debug("SMD: ch %d %d -> %d\n", ch->n, last, next);

	pr_debug("ch %d %d -> %d\n", ch->n, last, next);

  reply	other threads:[~2010-11-10  0:56 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-10  0:30 [PATCH] msm: smd: Reduce driver log chatter David Brown
2010-11-10  0:30 ` David Brown
2010-11-10  0:49 ` [PATCH v2] " David Brown
2010-11-10  0:49   ` David Brown
2010-11-10  0:56   ` Joe Perches [this message]
2010-11-10  0:56     ` Joe Perches
2010-11-10 17:59 ` [PATCH v3] " David Brown
2010-11-10 17:59   ` David Brown
2010-11-10 18:24   ` Joe Perches
2010-11-10 18:24     ` Joe Perches
2010-11-10 18:34     ` Brian Swetland
2010-11-10 18:34       ` Brian Swetland
2010-11-11 22:54 ` [PATCH v4] " David Brown
2010-11-11 22:54   ` David Brown
2010-11-12  4:22   ` Joe Perches
2010-11-12  4:22     ` Joe Perches
2010-11-12 21:49 ` [PATCH v5] " David Brown
2010-11-12 21:49   ` David Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1289350589.28590.74.camel@Joe-Laptop \
    --to=joe@perches.com \
    --cc=arve@android.com \
    --cc=davidb@codeaurora.org \
    --cc=dwalker@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=swetland@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.