RE: [PATCH v4] wl1271: Change wl12xx Files Names

[Luciano Coelho <luciano.coelho@nokia.com>]

On Wed, 2010-11-17 at 12:08 -0600, ext Gabay, Benzy wrote:
> Hi All,

Hi Benzy,


> > > What about wl1251 vs. wl12agn (or wl12bgn if no .11a support), like
> > iwlwifi?
> > 
> > Hmmm... wl1251 supports bg.  wl12xx supports abgn.  I don't really see
> > the logic in this? What difference does it make comparing to calling it
> > wl12xx? From wl12agn the user still doesn't know whether wl1251 is
> > supported or not. 
> 
> I have another idea for naming convention here.
> But first to align everyone on the TI chip conventions:
> 12x1 == support for 2.4Ghz
> 12x3 == supports both 2.4Ghz and 5.0Ghz.
> 
> The TI project naming convention per chip is as follow:
> 
> wilink4 == 1251 and 1253
> wilink6 == 1271 and 1273
> wilink7 == 1281 and 1281
> 
> So I propose to use the project name instead of using the chip name.
> e.g.: 
> for wl125x we can use: wl4 or wilink4. If we want to imply the band support: wl4_abg and wl4_bg
> for wl127x we can use: wl6 or wilink6. If we want to imply the band and capability support: wl6_abgn and wl4_bgn
> 
> etc'
> 
> What say?

Doesn't help much.  The problem is that the driver which is now called
wl12xx already support wl1271 and wl1273.  In the near future, it will
also support wl1281 and wl1283, so the wl6 or wilink6 scheme would break
already.

The wl1251 driver, at least at the moment, only supports wl1251, it
doesn't have the 11a implementation.  If in the future someone adds
support for wl1253, it could be renamed to wl125x.

In any case, I think the name of the driver is not that important, as
long as we're clear about which chips each one of them supports in the
Kconfig description.

Renaming the driver all the time (we already did it twice), ends up
confusing more than clarifying things.

-- 
Cheers,
Luca.