All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Love <robert.w.love@intel.com>
To: Dan Carpenter <error27@gmail.com>
Cc: "Dev, Vasu" <vasu.dev@intel.com>,
	"James E.J. Bottomley" <James.Bottomley@suse.de>,
	"devel@open-fcoe.org" <devel@open-fcoe.org>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>
Subject: Re: [patch] [SCSI] libfc: unlocking wrong lock in fc_eh_abort()
Date: Thu, 18 Nov 2010 19:02:13 +0000	[thread overview]
Message-ID: <1290106933.1482.78.camel@fritz> (raw)
In-Reply-To: <20101118041843.GN31724@bicker>

On Wed, 2010-11-17 at 20:18 -0800, Dan Carpenter wrote:
> In commit 8b7ac2bb07bb "[SCSI] libfc: possible race could panic system
> due to NULL fsp->cmd" we changed the lock which was used in this
> function, but this path was missed.
> 
> Signed-off-by: Dan Carpenter <error27@gmail.com>

Hi Dan,

   I found this bug too and have a patch in my tree.

Thanks, //Rob


WARNING: multiple messages have this Message-ID (diff)
From: Robert Love <robert.w.love@intel.com>
To: Dan Carpenter <error27@gmail.com>
Cc: "Dev, Vasu" <vasu.dev@intel.com>,
	"James E.J. Bottomley" <James.Bottomley@suse.de>,
	"devel@open-fcoe.org" <devel@open-fcoe.org>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>
Subject: Re: [patch] [SCSI] libfc: unlocking wrong lock in fc_eh_abort()
Date: Thu, 18 Nov 2010 11:02:13 -0800	[thread overview]
Message-ID: <1290106933.1482.78.camel@fritz> (raw)
In-Reply-To: <20101118041843.GN31724@bicker>

On Wed, 2010-11-17 at 20:18 -0800, Dan Carpenter wrote:
> In commit 8b7ac2bb07bb "[SCSI] libfc: possible race could panic system
> due to NULL fsp->cmd" we changed the lock which was used in this
> function, but this path was missed.
> 
> Signed-off-by: Dan Carpenter <error27@gmail.com>

Hi Dan,

   I found this bug too and have a patch in my tree.

Thanks, //Rob


  reply	other threads:[~2010-11-18 19:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-18  4:18 [patch] [SCSI] libfc: unlocking wrong lock in fc_eh_abort() Dan Carpenter
2010-11-18  4:18 ` Dan Carpenter
2010-11-18 19:02 ` Robert Love [this message]
2010-11-18 19:02   ` Robert Love

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1290106933.1482.78.camel@fritz \
    --to=robert.w.love@intel.com \
    --cc=James.Bottomley@suse.de \
    --cc=devel@open-fcoe.org \
    --cc=error27@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=vasu.dev@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.