All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <rpurdie@linux.intel.com>
To: Chris Larson <clarson@kergoth.com>
Cc: poky@yoctoproject.org
Subject: Re: [PATCH][RFC] bitbake: add task tracking
Date: Fri, 19 Nov 2010 12:18:30 +0000	[thread overview]
Message-ID: <1290169110.1272.12266.camel@rex> (raw)
In-Reply-To: <AANLkTi=qcEgerfv5skbCV6Ff+J+o_bJxkqwSnvg5C4kr@mail.gmail.com>

On Thu, 2010-11-18 at 21:13 -0700, Chris Larson wrote:
> On Thu, Nov 18, 2010 at 8:51 PM, Qing He <qing.he@intel.com> wrote:
>         Add a new option to record start and end time of every task
>         
>         Signed-off-by: Qing He <qing.he@intel.com>
> 
> 
> This is useful conceptually, and I'm glad to see others touching the
> bitbake code, so kudos on that, but implementation wise, I have
> concerns.  For one, this doesn't need to be in bitbake at all, it's
> quite easily implemented in the metadata using an event handler and
> the task events.  For two, hardcoding the log file and format seems
> unwise.

I agree, implementing this as an event handler would be a better
approach and allow more flexibility. 

Qing: I thought we'd already discussed that?

Cheers,

Richard




      reply	other threads:[~2010-11-19 12:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-19  3:51 [PATCH][RFC] bitbake: add task tracking Qing He
     [not found] ` <AANLkTik0YrJrrOrnA26H8aWDG6ZEmf-4p6buE=+B3N8U@mail.gmail.com>
2010-11-19  4:13   ` Chris Larson
2010-11-19 12:18     ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1290169110.1272.12266.camel@rex \
    --to=rpurdie@linux.intel.com \
    --cc=clarson@kergoth.com \
    --cc=poky@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.