From: Matt Mackall <mpm@selenic.com>
To: David Sterba <dsterba@suse.cz>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Andi Kleen <ak@linux.intel.com>,
Andy Whitcroft <apw@canonical.com>,
David Rientjes <rientjes@google.com>,
Hugh Dickins <hugh.dickins@tiscali.co.uk>,
Lee Schermerhorn <lee.schermerhorn@hp.com>,
Mel Gorman <mel@csn.ul.ie>, Wu Fengguang <fengguang.wu@intel.com>
Subject: Re: [PATCH] mm: remove call to find_vma in pagewalk for non-hugetlbfs
Date: Fri, 19 Nov 2010 14:09:17 -0600 [thread overview]
Message-ID: <1290197357.26343.944.camel@calx> (raw)
In-Reply-To: <1290127197-20360-1-git-send-email-dsterba@suse.cz>
On Fri, 2010-11-19 at 01:39 +0100, David Sterba wrote:
> Commit d33b9f45 introduces a check if a vma is a hugetlbfs one and
> later in 5dc37642 is moved under #ifdef CONFIG_HUGETLB_PAGE but
> a needless find_vma call is left behind and it's result not used
> anywhere else in the function.
>
> The sideefect of caching vma for @addr inside walk->mm is neither
> utilized in walk_page_range() nor in called functions.
Looks good to me.
Acked-by: Matt Mackall <mpm@selenic.com>
--
Mathematics is the supreme nostalgia of our time.
WARNING: multiple messages have this Message-ID (diff)
From: Matt Mackall <mpm@selenic.com>
To: David Sterba <dsterba@suse.cz>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Andi Kleen <ak@linux.intel.com>,
Andy Whitcroft <apw@canonical.com>,
David Rientjes <rientjes@google.com>,
Hugh Dickins <hugh.dickins@tiscali.co.uk>,
Lee Schermerhorn <lee.schermerhorn@hp.com>,
Mel Gorman <mel@csn.ul.ie>, Wu Fengguang <fengguang.wu@intel.com>
Subject: Re: [PATCH] mm: remove call to find_vma in pagewalk for non-hugetlbfs
Date: Fri, 19 Nov 2010 14:09:17 -0600 [thread overview]
Message-ID: <1290197357.26343.944.camel@calx> (raw)
In-Reply-To: <1290127197-20360-1-git-send-email-dsterba@suse.cz>
On Fri, 2010-11-19 at 01:39 +0100, David Sterba wrote:
> Commit d33b9f45 introduces a check if a vma is a hugetlbfs one and
> later in 5dc37642 is moved under #ifdef CONFIG_HUGETLB_PAGE but
> a needless find_vma call is left behind and it's result not used
> anywhere else in the function.
>
> The sideefect of caching vma for @addr inside walk->mm is neither
> utilized in walk_page_range() nor in called functions.
Looks good to me.
Acked-by: Matt Mackall <mpm@selenic.com>
--
Mathematics is the supreme nostalgia of our time.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-11-19 22:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-19 0:39 [PATCH] mm: remove call to find_vma in pagewalk for non-hugetlbfs David Sterba
2010-11-19 0:39 ` David Sterba
2010-11-19 8:15 ` Naoya Horiguchi
2010-11-19 8:15 ` Naoya Horiguchi
2010-11-19 11:35 ` Mel Gorman
2010-11-19 11:35 ` Mel Gorman
2010-11-19 20:09 ` Matt Mackall [this message]
2010-11-19 20:09 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290197357.26343.944.camel@calx \
--to=mpm@selenic.com \
--cc=ak@linux.intel.com \
--cc=apw@canonical.com \
--cc=dsterba@suse.cz \
--cc=fengguang.wu@intel.com \
--cc=hugh.dickins@tiscali.co.uk \
--cc=lee.schermerhorn@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.