From: David Brownell <david-b@pacbell.net>
To: Alexis RODET <alexis.rodet@bvs-tech.com>
Cc: spi-devel-general@lists.sourceforge.net,
linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] Renaming 'struct flash_platform_data' into 'struct spi_flash_platform_data' in include/linux/spi/flash.h
Date: Mon, 22 Nov 2010 05:59:29 -0800 [thread overview]
Message-ID: <1290434369.2529.38.camel@helium> (raw)
In-Reply-To: <4CEA3EAE.4080700@bvs-tech.com>
On Mon, 2010-11-22 at 10:58 +0100, Alexis RODET wrote:
> Hello,
>
> there is a problem with the double
> definition of 'struct flash_platform_data' that are incompatible:
>
> in arch/arm/include/asm/mach/flash.h:
> in include/linux/spi/flash.h:
>
>
> Both headers are included in a number of machines or driver.
And this patch doesn't touch machine or driver code, so it's incomplete.
ISTR the last time this issue was raised, a similar incomplete patch was
proposed.
How about a patch that does the full rename??
- Dave
WARNING: multiple messages have this Message-ID (diff)
From: David Brownell <david-b@pacbell.net>
To: Alexis RODET <alexis.rodet@bvs-tech.com>
Cc: spi-devel-general@lists.sourceforge.net,
linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] Renaming 'struct flash_platform_data' into 'struct spi_flash_platform_data' in include/linux/spi/flash.h
Date: Mon, 22 Nov 2010 05:59:29 -0800 [thread overview]
Message-ID: <1290434369.2529.38.camel@helium> (raw)
In-Reply-To: <4CEA3EAE.4080700@bvs-tech.com>
On Mon, 2010-11-22 at 10:58 +0100, Alexis RODET wrote:
> Hello,
>
> there is a problem with the double
> definition of 'struct flash_platform_data' that are incompatible:
>
> in arch/arm/include/asm/mach/flash.h:
> in include/linux/spi/flash.h:
>
>
> Both headers are included in a number of machines or driver.
And this patch doesn't touch machine or driver code, so it's incomplete.
ISTR the last time this issue was raised, a similar incomplete patch was
proposed.
How about a patch that does the full rename??
- Dave
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2010-11-22 13:59 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 15:40 Devel error: redefinition of 'struct flash_platform_data' Alexis RODET
2010-11-17 16:05 ` Russell King - ARM Linux
2010-11-18 9:34 ` [PATCH] Renaming 'struct flash_platform_data' into 'struct spi_flash_platform_data' in include/linux/spi/flash.h Alexis RODET
2010-11-18 9:34 ` [PATCH] Renaming 'struct flash_platform_data' into 'struct Alexis RODET
2010-11-19 17:23 ` [PATCH] Renaming 'struct flash_platform_data' into 'struct spi_flash_platform_data' in include/linux/spi/flash.h Alexis RODET
2010-11-21 4:47 ` Baruch Siach
2010-11-22 9:58 ` Alexis RODET
2010-11-22 9:58 ` Alexis RODET
2010-11-22 9:58 ` Alexis RODET
2010-11-22 13:59 ` David Brownell [this message]
2010-11-22 13:59 ` David Brownell
2010-11-22 14:15 ` Alexis RODET
2010-11-22 14:15 ` Alexis RODET
2010-11-22 21:52 ` David Brownell
2010-11-22 21:52 ` David Brownell
2010-11-23 9:30 ` Alexis RODET
2010-11-23 9:30 ` Alexis RODET
2010-11-23 9:36 ` Baruch Siach
2010-11-23 9:36 ` Baruch Siach
2010-11-23 9:41 ` Alexis RODET
2010-11-23 9:41 ` Alexis RODET
2010-11-23 9:44 ` Baruch Siach
2010-11-23 9:44 ` Baruch Siach
2010-11-23 9:55 ` Alexis RODET
2010-11-23 9:55 ` Alexis RODET
2011-01-21 19:28 ` Grant Likely
2011-01-21 19:28 ` Grant Likely
2011-01-24 11:37 ` [PATCH 0/1] " Alexis RODET
2011-01-24 11:37 ` Alexis RODET
[not found] ` <4D3D6472.8030505-zROAmvwsW6hWk0Htik3J/w@public.gmane.org>
2011-01-24 15:16 ` [PATCH 1/1] " Alexis RODET
2011-01-24 15:16 ` Alexis RODET
2011-01-24 15:16 ` Alexis RODET
2011-01-24 15:49 ` [PATCH 0/1] " Alexis RODET
2011-01-24 15:49 ` Alexis RODET
2011-01-24 17:52 ` Grant Likely
2011-01-24 17:52 ` Grant Likely
2011-01-25 9:23 ` Alexis RODET
2011-01-25 9:23 ` Alexis RODET
2011-01-31 11:29 ` [PATCH 1/1] merging arch/arm/include/asm/mach/flash.h and include/linux/spi/flash.h into single header file include/linux/mtd/flash.h Alexis RODET
2011-01-31 11:29 ` Alexis RODET
2011-07-10 7:38 ` Grant Likely
2011-07-10 7:38 ` Grant Likely
2011-01-31 11:29 ` Alexis RODET
2011-01-25 9:40 ` [PATCH 0/1] Renaming 'struct flash_platform_data' into 'struct spi_flash_platform_data' in include/linux/spi/flash.h Alexis RODET
2011-01-25 9:40 ` Alexis RODET
2011-01-26 14:35 ` Josh Boyer
2011-01-26 14:35 ` Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290434369.2529.38.camel@helium \
--to=david-b@pacbell.net \
--cc=alexis.rodet@bvs-tech.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.