From: Peter Zijlstra <peterz@infradead.org>
To: Namhyung Kim <namhyung@gmail.com>
Cc: Dan Carpenter <error27@gmail.com>,
Jens Axboe <jaxboe@fusionio.com>, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] generic-ipi: add lock context annotations
Date: Wed, 24 Nov 2010 15:33:34 +0100 [thread overview]
Message-ID: <1290609214.2072.476.camel@laptop> (raw)
In-Reply-To: <1290608996.1675.2.camel@leonhard>
On Wed, 2010-11-24 at 23:29 +0900, Namhyung Kim wrote:
> 2010-11-24 (수), 08:43 +0300, Dan Carpenter:
> > On Wed, Nov 24, 2010 at 02:24:40PM +0900, Namhyung Kim wrote:
> > > 2010-11-23 (화), 12:40 +0300, Dan Carpenter:
> > > > On Tue, Nov 23, 2010 at 09:49:56AM +0100, Jens Axboe wrote:
> > >
> > > I tried to annotate declations in include/linux/smp.h but it didn't work
> > > well. Maybe that's what we need to fix the sparse?
> > >
> >
> > It worked for me earlier when I tested it. Just add the exact same
> > annotations that you added to the .c file.
> >
> > regards,
> > dan carpenter
> >
>
> OK. You mean annotating both .c and .h, right? Will send v2 soon.
Aside from complain, do these sparse annotations ever catch a bug?
I don't particularly like the __acquire() and __release() tags, but
could possibly live with them when they only need to be in headers, but
the __cond_lock() crap is just revolting.
next prev parent reply other threads:[~2010-11-24 14:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-22 7:33 [PATCH] generic-ipi: add lock context annotations Namhyung Kim
2010-11-22 12:46 ` Peter Zijlstra
2010-11-23 3:19 ` Namhyung Kim
2010-11-23 8:49 ` Jens Axboe
2010-11-23 9:40 ` Dan Carpenter
2010-11-24 5:24 ` Namhyung Kim
2010-11-24 5:43 ` Dan Carpenter
2010-11-24 14:29 ` Namhyung Kim
2010-11-24 14:33 ` Peter Zijlstra [this message]
2010-11-24 15:03 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290609214.2072.476.camel@laptop \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=error27@gmail.com \
--cc=jaxboe@fusionio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.