From: Dan Carpenter <error27@gmail.com>
To: Jens Axboe <jaxboe@fusionio.com>
Cc: Namhyung Kim <namhyung@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] generic-ipi: add lock context annotations
Date: Tue, 23 Nov 2010 12:40:16 +0300 [thread overview]
Message-ID: <20101123094016.GC8882@bicker> (raw)
In-Reply-To: <4CEB8034.80400@fusionio.com>
On Tue, Nov 23, 2010 at 09:49:56AM +0100, Jens Axboe wrote:
> I guess what Peter means is that the fact that the function grabs the
> lock is apparent in the code, if sparse was a bit "smarter", it would
> see and note this itself.
The sparse warning messages should have been included in the commit
message. Here they are:
kernel/smp.c:513:6: warning: context imbalance in 'ipi_call_lock' - wrong count at exit
kernel/smp.c:518:6: warning: context imbalance in 'ipi_call_unlock' - unexpected unlock
kernel/smp.c:523:6: warning: context imbalance in 'ipi_call_lock_irq' - wrong count at exit
kernel/smp.c:528:6: warning: context imbalance in 'ipi_call_unlock_irq' - unexpected unlock
What happens is that sparse *does* see that the locks are unlocked and
that's what it complains about.
Sparse works before the code is linked so this change doesn't affect
anything outside kernel/smp.c. If we added these annotations to
include/linux/smp.h then they would be used for checking
kernel/smpboot.c
regards,
dan carpenter
next prev parent reply other threads:[~2010-11-23 9:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-22 7:33 [PATCH] generic-ipi: add lock context annotations Namhyung Kim
2010-11-22 12:46 ` Peter Zijlstra
2010-11-23 3:19 ` Namhyung Kim
2010-11-23 8:49 ` Jens Axboe
2010-11-23 9:40 ` Dan Carpenter [this message]
2010-11-24 5:24 ` Namhyung Kim
2010-11-24 5:43 ` Dan Carpenter
2010-11-24 14:29 ` Namhyung Kim
2010-11-24 14:33 ` Peter Zijlstra
2010-11-24 15:03 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101123094016.GC8882@bicker \
--to=error27@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jaxboe@fusionio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung@gmail.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.