* [PATCH] ASoC: davinci-vcif - fix a memory leak
@ 2010-11-25 3:33 Axel Lin
2010-11-25 10:46 ` Liam Girdwood
2010-11-25 11:12 ` Mark Brown
0 siblings, 2 replies; 5+ messages in thread
From: Axel Lin @ 2010-11-25 3:33 UTC (permalink / raw)
To: linux-kernel
Cc: Miguel Aguilar, Liam Girdwood, Mark Brown, Jarkko Nikula,
alsa-devel
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
sound/soc/davinci/davinci-vcif.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/sound/soc/davinci/davinci-vcif.c b/sound/soc/davinci/davinci-vcif.c
index fb4cc1e..9d2afcc 100644
--- a/sound/soc/davinci/davinci-vcif.c
+++ b/sound/soc/davinci/davinci-vcif.c
@@ -247,7 +247,10 @@ fail:
static int davinci_vcif_remove(struct platform_device *pdev)
{
+ struct davinci_vcif_dev *davinci_vcif_dev = dev_get_drvdata(&pdev->dev);
+
snd_soc_unregister_dai(&pdev->dev);
+ kfree(davinci_vcif_dev);
return 0;
}
--
1.7.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ASoC: davinci-vcif - fix a memory leak
2010-11-25 3:33 [PATCH] ASoC: davinci-vcif - fix a memory leak Axel Lin
@ 2010-11-25 10:46 ` Liam Girdwood
2010-11-25 11:12 ` Mark Brown
1 sibling, 0 replies; 5+ messages in thread
From: Liam Girdwood @ 2010-11-25 10:46 UTC (permalink / raw)
To: Axel Lin; +Cc: alsa-devel, Mark Brown, linux-kernel, Miguel Aguilar
On Thu, 2010-11-25 at 11:33 +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> sound/soc/davinci/davinci-vcif.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/davinci/davinci-vcif.c b/sound/soc/davinci/davinci-vcif.c
> index fb4cc1e..9d2afcc 100644
> --- a/sound/soc/davinci/davinci-vcif.c
> +++ b/sound/soc/davinci/davinci-vcif.c
> @@ -247,7 +247,10 @@ fail:
>
> static int davinci_vcif_remove(struct platform_device *pdev)
> {
> + struct davinci_vcif_dev *davinci_vcif_dev = dev_get_drvdata(&pdev->dev);
> +
> snd_soc_unregister_dai(&pdev->dev);
> + kfree(davinci_vcif_dev);
>
> return 0;
> }
Acked-by: Liam Girdwood <lrg@slimlogic.o.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ASoC: davinci-vcif - fix a memory leak
@ 2010-11-25 10:46 ` Liam Girdwood
0 siblings, 0 replies; 5+ messages in thread
From: Liam Girdwood @ 2010-11-25 10:46 UTC (permalink / raw)
To: Axel Lin
Cc: linux-kernel, Miguel Aguilar, Mark Brown, Jarkko Nikula,
alsa-devel
On Thu, 2010-11-25 at 11:33 +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> sound/soc/davinci/davinci-vcif.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/davinci/davinci-vcif.c b/sound/soc/davinci/davinci-vcif.c
> index fb4cc1e..9d2afcc 100644
> --- a/sound/soc/davinci/davinci-vcif.c
> +++ b/sound/soc/davinci/davinci-vcif.c
> @@ -247,7 +247,10 @@ fail:
>
> static int davinci_vcif_remove(struct platform_device *pdev)
> {
> + struct davinci_vcif_dev *davinci_vcif_dev = dev_get_drvdata(&pdev->dev);
> +
> snd_soc_unregister_dai(&pdev->dev);
> + kfree(davinci_vcif_dev);
>
> return 0;
> }
Acked-by: Liam Girdwood <lrg@slimlogic.o.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: davinci-vcif - fix a memory leak
2010-11-25 3:33 [PATCH] ASoC: davinci-vcif - fix a memory leak Axel Lin
@ 2010-11-25 11:12 ` Mark Brown
2010-11-25 11:12 ` Mark Brown
1 sibling, 0 replies; 5+ messages in thread
From: Mark Brown @ 2010-11-25 11:12 UTC (permalink / raw)
To: Axel Lin; +Cc: alsa-devel, linux-kernel, Miguel Aguilar, Liam Girdwood
On Thu, Nov 25, 2010 at 11:33:14AM +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-11-25 11:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-25 3:33 [PATCH] ASoC: davinci-vcif - fix a memory leak Axel Lin
2010-11-25 10:46 ` Liam Girdwood
2010-11-25 10:46 ` Liam Girdwood
2010-11-25 11:12 ` Mark Brown
2010-11-25 11:12 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.