From: Richard Purdie <rpurdie@linux.intel.com>
To: Paul Eggleton <paul.eggleton@intel.com>
Cc: "poky@pokylinux.org" <poky@pokylinux.org>
Subject: Re: [PATCH 3/3] qemu: fix failure to find zlib header files during configure
Date: Sun, 28 Nov 2010 14:41:40 +0000 [thread overview]
Message-ID: <1290955300.27143.241.camel@rex> (raw)
In-Reply-To: <201011221718.57086.paul.eggleton@intel.com>
On Mon, 2010-11-22 at 17:18 +0000, Paul Eggleton wrote:
> On Monday 22 November 2010 17:05:11 Richard Purdie wrote:
> > Should this be $CFLAGS? I just wonder what the effect of injecting
> > BUILD_CFLAGS would be in the target case (qemu vs. qemu-native)?
> >
> > In the native case CFLAGS == BUILD_CFLAGS.
>
> Yes, actually the initial version of my patch used CFLAGS which works
> just fine (for qemu-native, I have to admit to not testing qemu), so
> I'm happy to for that to be changed.
Ok, I think it was me who suggested BUILD_CFLAGS to Joshua as I thought
this was a native only patch. Using CFLAGS in this context is fine.
I've updated the patch and also added a header to the patch indicating
what problem it solves and why its there. Please try and ensure you add
that next time as it really helps when you look at the patch again 12
months later and wonder what it does!
Cheers,
Richard
next prev parent reply other threads:[~2010-11-28 21:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-22 10:53 [PATCH 0/3] Patches for successful Fedora 14 build Paul Eggleton
2010-11-17 11:37 ` [PATCH 1/3] openssl: disable execstack flag to prevent problems with SELinux Paul Eggleton
2010-11-22 19:22 ` Richard Purdie
2010-11-23 11:00 ` Paul Eggleton
2010-11-18 11:34 ` [PATCH 2/3] sanity.bbclass: add wget to required utilities Paul Eggleton
2010-11-19 12:37 ` [PATCH 3/3] qemu: fix failure to find zlib header files during configure Paul Eggleton
2010-11-22 17:05 ` Richard Purdie
2010-11-22 17:18 ` Paul Eggleton
2010-11-28 14:41 ` Richard Purdie [this message]
2010-11-29 10:28 ` Paul Eggleton
2010-11-29 11:48 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290955300.27143.241.camel@rex \
--to=rpurdie@linux.intel.com \
--cc=paul.eggleton@intel.com \
--cc=poky@pokylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.