All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Richard Purdie <rpurdie@linux.intel.com>
Cc: "poky@pokylinux.org" <poky@pokylinux.org>
Subject: Re: [PATCH 3/3] qemu: fix failure to find zlib header files during configure
Date: Mon, 29 Nov 2010 10:28:04 +0000	[thread overview]
Message-ID: <201011291028.04628.paul.eggleton@linux.intel.com> (raw)
In-Reply-To: <1290955300.27143.241.camel@rex>

On Sunday 28 November 2010 14:41:40 Richard Purdie wrote:
> I've updated the patch and also added a header to the patch indicating
> what problem it solves and why its there. Please try and ensure you add
> that next time as it really helps when you look at the patch again 12
> months later and wonder what it does!

That's a good point, but actually Joshua already mentioned this and that's why in the (revised) posted patch you're replying to you'll see there is a note at the top of the source patch explaining what it does. ;)

Of course I will endeavour to include this on all future source patches (and mark revised patches more clearly when posting to the list).

Cheers,
Paul


  reply	other threads:[~2010-11-29 10:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-22 10:53 [PATCH 0/3] Patches for successful Fedora 14 build Paul Eggleton
2010-11-17 11:37 ` [PATCH 1/3] openssl: disable execstack flag to prevent problems with SELinux Paul Eggleton
2010-11-22 19:22   ` Richard Purdie
2010-11-23 11:00     ` Paul Eggleton
2010-11-18 11:34 ` [PATCH 2/3] sanity.bbclass: add wget to required utilities Paul Eggleton
2010-11-19 12:37 ` [PATCH 3/3] qemu: fix failure to find zlib header files during configure Paul Eggleton
2010-11-22 17:05   ` Richard Purdie
2010-11-22 17:18     ` Paul Eggleton
2010-11-28 14:41       ` Richard Purdie
2010-11-29 10:28         ` Paul Eggleton [this message]
2010-11-29 11:48           ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201011291028.04628.paul.eggleton@linux.intel.com \
    --to=paul.eggleton@linux.intel.com \
    --cc=poky@pokylinux.org \
    --cc=rpurdie@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.