All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <rpurdie@linux.intel.com>
To: Qing He <qing.he@intel.com>
Cc: "poky@yoctoproject.org" <poky@yoctoproject.org>
Subject: Re: [PATCH 1/1] curl: fix native dependency
Date: Mon, 29 Nov 2010 03:57:26 -0800	[thread overview]
Message-ID: <1291031846.14277.907.camel@rex> (raw)
In-Reply-To: <20101129081747.GA10141@qhe2-db>

On Mon, 2010-11-29 at 16:17 +0800, Qing He wrote:
> On Sun, 2010-11-28 at 22:22 +0800, Richard Purdie wrote:
> > On Wed, 2010-11-17 at 16:26 +0800, Qing He wrote:
> > > @@ -25,6 +24,10 @@ EXTRA_OECONF = "--with-zlib=${STAGING_LIBDIR}/../ \
> > >  		--enable-crypto-auth \
> > >  		"
> > >  
> > > +EXTRA_OECONF_append = " --with-gnutls=${STAGING_LIBDIR}/../"
> > > +EXTRA_OECONF_virtclass-native_append = " --without-gnutls"
> > > +EXTRA_OECONF_virtclass-nativesdk_append = " --without-gnutls"
> > > +
> > >  do_configure_prepend() {
> > >  	sed -i s:OPT_GNUTLS/bin:OPT_GNUTLS:g configure.ac
> > >  }
> > 
> > I'm going to push a fix but I wanted to note that the above is not
> > correct. Let me walk through this since I expect various people find
> > this confusing.
> 
> Thanks for the explanation.
> 
> In fact, at first, I also tried to use
> EXTRA_OECONF_append_virtclass-native, in the hope to override variable
> EXTRA_OECONF_append for different virtual classes. However, the
> log.do_configure still showed "--with-gnutls=...", that's why I then
> changed to the form in the patch, and it looked working.
> 
> 
> And I also see something in the smart data implementation:
>     __setvar_regexp__ = re.compile('(?P<base>.*?)(?P<keyword>_append|_prepend)(_(?P<add>.*))?')
> 
> Does that mean append/prepend is expected to appear before everything
> else?

It means append and prepend only work if they're the last part of the
variable name.

e.g. XXX_append = "YYY"

so XXX_append_ZZZ = "YYY" won't do anything

of course if ZZZ is an override, it will be peeled off but the append
only happens after its been overridden and it becomes XXX_append

Cheers,

Richard



  reply	other threads:[~2010-11-29 11:57 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-17  8:32 [PATCH 0/1] curl-native build fix Qing He
2010-11-17  8:26 ` [PATCH 1/1] curl: fix native dependency Qing He
2010-11-28 14:22   ` Richard Purdie
2010-11-29  5:26     ` Tian, Kevin
2010-11-29  5:53       ` Chris Larson
2010-11-29  5:58         ` Tian, Kevin
2010-11-29 12:25         ` Richard Purdie
2010-11-29 13:04           ` Frans Meulenbroeks
2010-11-29 15:17             ` Richard Purdie
2010-12-05  9:48               ` Tian, Kevin
2010-11-29 15:24           ` Chris Larson
2010-12-05  9:32             ` Tian, Kevin
2010-12-06  1:04               ` Richard Purdie
2010-12-07  7:55                 ` Tian, Kevin
2010-12-07 12:37                   ` Richard Purdie
2010-12-08  3:12                     ` Qing He
2010-12-09 15:16                       ` Richard Purdie
2010-12-13  5:52                         ` Qing He
2010-12-13 10:48                           ` Qing He
2010-11-30  1:44           ` Qing He
2010-12-05  9:43             ` Tian, Kevin
2010-12-06  1:10               ` Richard Purdie
2010-12-07  7:56                 ` Tian, Kevin
2010-11-29  8:17     ` Qing He
2010-11-29 11:57       ` Richard Purdie [this message]
2010-11-17 18:21 ` [PATCH 0/1] curl-native build fix Saul Wold
2010-11-17 18:26   ` Scott Garman
2010-11-19 22:43     ` Saul Wold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1291031846.14277.907.camel@rex \
    --to=rpurdie@linux.intel.com \
    --cc=poky@yoctoproject.org \
    --cc=qing.he@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.