All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <rpurdie@linux.intel.com>
To: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
Cc: Chris Larson <clarson@kergoth.com>,
	"poky@yoctoproject.org" <poky@yoctoproject.org>
Subject: Re: [PATCH 1/1] curl: fix native dependency
Date: Mon, 29 Nov 2010 07:17:07 -0800	[thread overview]
Message-ID: <1291043827.14277.1149.camel@rex> (raw)
In-Reply-To: <AANLkTi=3f9NUcm3+1xNz2bL0+gaasfGN8-bU6Zov6Ut-@mail.gmail.com>

On Mon, 2010-11-29 at 14:04 +0100, Frans Meulenbroeks wrote:
> 2010/11/29 Richard Purdie <rpurdie@linux.intel.com>:
> > Interestingly though, if I add this to curl*.bb:
> >
> > FOO = "A"
> > FOO_append = "B"
> > FOO_append_virtclass-native = "C"
> >
> > and then "bitbake curl-native -e | grep FOO" (he recipe has a
> > BBCLASSEXTEND native) what should I see?
> >
> > I see FOO = "AB" which is not what I thought it would do...
> >
> 
> Hm.
> Please allow me the remark that, if this does not do what you as
> expert expect it to to, that probably for mere mortals like me, this
> is a construct that is way too complicated.

Its not that its too complicated, its just that its not following what
I've understood to be the rules that variables follow. This is probably
a bug in the parser but I'm very careful about jumping to that
conclusion as there could be another explanation, not least the way
virtclass as an override is implemented. I'd be interested in Chris'
opinion which is why I was non-committal in calling it a bug ;-).

> What is the rationale that _append is not a variable? Wouldn't it be
> more logical/orthogonal/clearer if it was (and get appended at the end
> as most people seem to expect/assume)

The point is that appends should stack and this is exactly the same as
normal variable rules, e.g.:

FOO = "A"
FOO += "B"
FOO += "C"

and you'd expect the result to be "A B C", not "A C" which it would be
if += was the append operator did not stack.

Cheers,

Richard



  reply	other threads:[~2010-11-29 15:17 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-17  8:32 [PATCH 0/1] curl-native build fix Qing He
2010-11-17  8:26 ` [PATCH 1/1] curl: fix native dependency Qing He
2010-11-28 14:22   ` Richard Purdie
2010-11-29  5:26     ` Tian, Kevin
2010-11-29  5:53       ` Chris Larson
2010-11-29  5:58         ` Tian, Kevin
2010-11-29 12:25         ` Richard Purdie
2010-11-29 13:04           ` Frans Meulenbroeks
2010-11-29 15:17             ` Richard Purdie [this message]
2010-12-05  9:48               ` Tian, Kevin
2010-11-29 15:24           ` Chris Larson
2010-12-05  9:32             ` Tian, Kevin
2010-12-06  1:04               ` Richard Purdie
2010-12-07  7:55                 ` Tian, Kevin
2010-12-07 12:37                   ` Richard Purdie
2010-12-08  3:12                     ` Qing He
2010-12-09 15:16                       ` Richard Purdie
2010-12-13  5:52                         ` Qing He
2010-12-13 10:48                           ` Qing He
2010-11-30  1:44           ` Qing He
2010-12-05  9:43             ` Tian, Kevin
2010-12-06  1:10               ` Richard Purdie
2010-12-07  7:56                 ` Tian, Kevin
2010-11-29  8:17     ` Qing He
2010-11-29 11:57       ` Richard Purdie
2010-11-17 18:21 ` [PATCH 0/1] curl-native build fix Saul Wold
2010-11-17 18:26   ` Scott Garman
2010-11-19 22:43     ` Saul Wold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1291043827.14277.1149.camel@rex \
    --to=rpurdie@linux.intel.com \
    --cc=clarson@kergoth.com \
    --cc=fransmeulenbroeks@gmail.com \
    --cc=poky@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.