From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH 1/2] ASoC: tlv320dac33: Do not enable the codec in init_chip
Date: Tue, 30 Nov 2010 15:45:10 +0000 [thread overview]
Message-ID: <1291131910.3293.19.camel@odin> (raw)
In-Reply-To: <1291120306-18445-2-git-send-email-peter.ujfalusi@nokia.com>
On Tue, 2010-11-30 at 14:31 +0200, Peter Ujfalusi wrote:
> No need to enable the codec at this time.
> The codec will be enabled later by other events
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
> ---
> sound/soc/codecs/tlv320dac33.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/codecs/tlv320dac33.c b/sound/soc/codecs/tlv320dac33.c
> index ccb267f..080ec91 100644
> --- a/sound/soc/codecs/tlv320dac33.c
> +++ b/sound/soc/codecs/tlv320dac33.c
> @@ -315,8 +315,6 @@ static void dac33_init_chip(struct snd_soc_codec *codec)
> clock source = internal osc (?) */
> dac33_write(codec, DAC33_ANA_VOL_SOFT_STEP_CTRL, DAC33_VOLCLKEN);
>
> - dac33_write(codec, DAC33_PWR_CTRL, DAC33_PDNALLB);
> -
> /* Restore only selected registers (gains mostly) */
> dac33_write(codec, DAC33_LDAC_DIG_VOL_CTRL,
> dac33_read_reg_cache(codec, DAC33_LDAC_DIG_VOL_CTRL));
Both Applied.
Thanks
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2010-11-30 15:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-30 12:31 [PATCH 0/2] ASoC: tlv320dac33: codec enable fixes Peter Ujfalusi
2010-11-30 12:31 ` [PATCH 1/2] ASoC: tlv320dac33: Do not enable the codec in init_chip Peter Ujfalusi
2010-11-30 12:41 ` Mark Brown
2010-11-30 15:45 ` Liam Girdwood [this message]
2010-11-30 12:31 ` [PATCH 2/2] ASoC: tlv320dac33: Avoid multiple soft power up Peter Ujfalusi
2010-11-30 12:41 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291131910.3293.19.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.