[PATCH 0/2] ASoC: tlv320dac33: codec enable fixes

[PATCH 0/2] ASoC: tlv320dac33: codec enable fixes

[Peter Ujfalusi]

Hello,

two small fixes to avoid duplicated codec enable, which reduces
i2c access to the chip.

---
Peter Ujfalusi (2):
  ASoC: tlv320dac33: Do not enable the codec in init_chip
  ASoC: tlv320dac33: Avoid multiple soft power up

 sound/soc/codecs/tlv320dac33.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

-- 
1.7.3.2

[PATCH 1/2] ASoC: tlv320dac33: Do not enable the codec in init_chip

[Peter Ujfalusi]

No need to enable the codec at this time.
The codec will be enabled  later by other events

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
---
 sound/soc/codecs/tlv320dac33.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/sound/soc/codecs/tlv320dac33.c b/sound/soc/codecs/tlv320dac33.c
index ccb267f..080ec91 100644
--- a/sound/soc/codecs/tlv320dac33.c
+++ b/sound/soc/codecs/tlv320dac33.c
@@ -315,8 +315,6 @@ static void dac33_init_chip(struct snd_soc_codec *codec)
 	 clock source = internal osc (?) */
 	dac33_write(codec, DAC33_ANA_VOL_SOFT_STEP_CTRL, DAC33_VOLCLKEN);
 
-	dac33_write(codec, DAC33_PWR_CTRL, DAC33_PDNALLB);
-
 	/* Restore only selected registers (gains mostly) */
 	dac33_write(codec, DAC33_LDAC_DIG_VOL_CTRL,
 		    dac33_read_reg_cache(codec, DAC33_LDAC_DIG_VOL_CTRL));
-- 
1.7.3.2

[PATCH 2/2] ASoC: tlv320dac33: Avoid multiple soft power up

[Peter Ujfalusi]

During playback start the codec has been already powered at
BIAS_ON event time, so there's no need to enable the codec again.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
---
 sound/soc/codecs/tlv320dac33.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/sound/soc/codecs/tlv320dac33.c b/sound/soc/codecs/tlv320dac33.c
index 080ec91..a0ba5d1 100644
--- a/sound/soc/codecs/tlv320dac33.c
+++ b/sound/soc/codecs/tlv320dac33.c
@@ -642,7 +642,8 @@ static int dac33_set_bias_level(struct snd_soc_codec *codec,
 
 	switch (level) {
 	case SND_SOC_BIAS_ON:
-		dac33_soft_power(codec, 1);
+		if (!dac33->substream)
+			dac33_soft_power(codec, 1);
 		break;
 	case SND_SOC_BIAS_PREPARE:
 		break;
-- 
1.7.3.2

Re: [PATCH 1/2] ASoC: tlv320dac33: Do not enable the codec in init_chip

[Mark Brown]

On Tue, Nov 30, 2010 at 02:31:45PM +0200, Peter Ujfalusi wrote:
> No need to enable the codec at this time.
> The codec will be enabled  later by other events
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>

Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

Re: [PATCH 2/2] ASoC: tlv320dac33: Avoid multiple soft power up

[Mark Brown]

On Tue, Nov 30, 2010 at 02:31:46PM +0200, Peter Ujfalusi wrote:
> During playback start the codec has been already powered at
> BIAS_ON event time, so there's no need to enable the codec again.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>

Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

Re: [PATCH 1/2] ASoC: tlv320dac33: Do not enable the codec in init_chip

[Liam Girdwood]

On Tue, 2010-11-30 at 14:31 +0200, Peter Ujfalusi wrote:
> No need to enable the codec at this time.
> The codec will be enabled  later by other events
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
> ---
>  sound/soc/codecs/tlv320dac33.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/codecs/tlv320dac33.c b/sound/soc/codecs/tlv320dac33.c
> index ccb267f..080ec91 100644
> --- a/sound/soc/codecs/tlv320dac33.c
> +++ b/sound/soc/codecs/tlv320dac33.c
> @@ -315,8 +315,6 @@ static void dac33_init_chip(struct snd_soc_codec *codec)
>  	 clock source = internal osc (?) */
>  	dac33_write(codec, DAC33_ANA_VOL_SOFT_STEP_CTRL, DAC33_VOLCLKEN);
>  
> -	dac33_write(codec, DAC33_PWR_CTRL, DAC33_PDNALLB);
> -
>  	/* Restore only selected registers (gains mostly) */
>  	dac33_write(codec, DAC33_LDAC_DIG_VOL_CTRL,
>  		    dac33_read_reg_cache(codec, DAC33_LDAC_DIG_VOL_CTRL));

Both Applied.

Thanks

Liam
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk