From: Joe Perches <joe@perches.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH 2/2] ath: Fix logging message typos
Date: Wed, 01 Dec 2010 21:34:47 -0800 [thread overview]
Message-ID: <1291268087.1761.3.camel@Joe-Laptop> (raw)
In-Reply-To: <20101202053055.19479.qmail@stuge.se>
On Thu, 2010-12-02 at 06:30 +0100, Peter Stuge wrote:
> Joe Perches wrote:
> > +++ b/drivers/net/wireless/ath/ath9k/ar9002_calib.c
> ..
> > @@ -734,7 +734,7 @@ static bool ar9285_hw_cl_cal(struct ath_hw *ah, struct ath9k_channel *chan)
> > if (!ath9k_hw_wait(ah, AR_PHY_AGC_CONTROL, AR_PHY_AGC_CONTROL_CAL,
> > 0, AH_WAIT_TIMEOUT)) {
> > ath_dbg(common, ATH_DBG_CALIBRATE,
> > - "offset calibration failed to complete in 1ms; noisy ??\n");
> > + "offset calibration failed to complete in 1ms; noisy enfironment?\n");
>
> enfironment? :)
Umm, what's a typo fix patch without more typos?
Correct? How dull...
> > ath_dbg(common, ATH_DBG_ANI,
> > - "Getting spur idx %d is2Ghz. %d val %x\n",
> > + "Getting spur idx:%d is2Ghz:%d val:%x\n",
> > i, is2GHz, ah->config.spurchans[i][is2GHz]);
>
> Is this short for "spurious" ?
Likely. Anyone want to change it to a whole word?
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Peter Stuge <peter@stuge.se>
Cc: Jiri Slaby <jirislaby@gmail.com>,
Nick Kossifidis <mickflemm@gmail.com>,
"Luis R. Rodriguez" <lrodriguez@atheros.com>,
Bob Copeland <me@bobcopeland.com>,
Jouni Malinen <jmalinen@atheros.com>,
Vasanthakumar Thiagarajan <vasanth@atheros.com>,
Senthil Balasubramanian <senthilkumar@atheros.com>,
netdev@vger.kernel.org, ath5k-devel@lists.ath5k.org,
linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
linux-kernel@vger.kernel.org, ath9k-devel@lists.ath9k.org
Subject: Re: [ath9k-devel] [PATCH 2/2] ath: Fix logging message typos
Date: Wed, 01 Dec 2010 21:34:47 -0800 [thread overview]
Message-ID: <1291268087.1761.3.camel@Joe-Laptop> (raw)
In-Reply-To: <20101202053055.19479.qmail@stuge.se>
On Thu, 2010-12-02 at 06:30 +0100, Peter Stuge wrote:
> Joe Perches wrote:
> > +++ b/drivers/net/wireless/ath/ath9k/ar9002_calib.c
> ..
> > @@ -734,7 +734,7 @@ static bool ar9285_hw_cl_cal(struct ath_hw *ah, struct ath9k_channel *chan)
> > if (!ath9k_hw_wait(ah, AR_PHY_AGC_CONTROL, AR_PHY_AGC_CONTROL_CAL,
> > 0, AH_WAIT_TIMEOUT)) {
> > ath_dbg(common, ATH_DBG_CALIBRATE,
> > - "offset calibration failed to complete in 1ms; noisy ??\n");
> > + "offset calibration failed to complete in 1ms; noisy enfironment?\n");
>
> enfironment? :)
Umm, what's a typo fix patch without more typos?
Correct? How dull...
> > ath_dbg(common, ATH_DBG_ANI,
> > - "Getting spur idx %d is2Ghz. %d val %x\n",
> > + "Getting spur idx:%d is2Ghz:%d val:%x\n",
> > i, is2GHz, ah->config.spurchans[i][is2GHz]);
>
> Is this short for "spurious" ?
Likely. Anyone want to change it to a whole word?
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Peter Stuge <peter@stuge.se>
Cc: Jiri Slaby <jirislaby@gmail.com>,
Nick Kossifidis <mickflemm@gmail.com>,
"Luis R. Rodriguez" <lrodriguez@atheros.com>,
Bob Copeland <me@bobcopeland.com>,
Jouni Malinen <jmalinen@atheros.com>,
Vasanthakumar Thiagarajan <vasanth@atheros.com>,
Senthil Balasubramanian <senthilkumar@atheros.com>,
netdev@vger.kernel.org, ath5k-devel@venema.h4ckr.net,
linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
linux-kernel@vger.kernel.org, ath9k-devel@venema.h4ckr.net
Subject: Re: [ath9k-devel] [PATCH 2/2] ath: Fix logging message typos
Date: Wed, 01 Dec 2010 21:34:47 -0800 [thread overview]
Message-ID: <1291268087.1761.3.camel@Joe-Laptop> (raw)
In-Reply-To: <20101202053055.19479.qmail@stuge.se>
On Thu, 2010-12-02 at 06:30 +0100, Peter Stuge wrote:
> Joe Perches wrote:
> > +++ b/drivers/net/wireless/ath/ath9k/ar9002_calib.c
> ..
> > @@ -734,7 +734,7 @@ static bool ar9285_hw_cl_cal(struct ath_hw *ah, struct ath9k_channel *chan)
> > if (!ath9k_hw_wait(ah, AR_PHY_AGC_CONTROL, AR_PHY_AGC_CONTROL_CAL,
> > 0, AH_WAIT_TIMEOUT)) {
> > ath_dbg(common, ATH_DBG_CALIBRATE,
> > - "offset calibration failed to complete in 1ms; noisy ??\n");
> > + "offset calibration failed to complete in 1ms; noisy enfironment?\n");
>
> enfironment? :)
Umm, what's a typo fix patch without more typos?
Correct? How dull...
> > ath_dbg(common, ATH_DBG_ANI,
> > - "Getting spur idx %d is2Ghz. %d val %x\n",
> > + "Getting spur idx:%d is2Ghz:%d val:%x\n",
> > i, is2GHz, ah->config.spurchans[i][is2GHz]);
>
> Is this short for "spurious" ?
Likely. Anyone want to change it to a whole word?
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
To: Peter Stuge <peter-Y+HMSxxDrH8@public.gmane.org>
Cc: Jiri Slaby <jirislaby-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Nick Kossifidis
<mickflemm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"Luis R. Rodriguez"
<lrodriguez-DlyHzToyqoxBDgjK7y7TUQ@public.gmane.org>,
Bob Copeland <me-aXfl/3sk2vNUbtYUoyoikg@public.gmane.org>,
Jouni Malinen <jmalinen-DlyHzToyqoxBDgjK7y7TUQ@public.gmane.org>,
Vasanthakumar Thiagarajan
<vasanth-DlyHzToyqoxBDgjK7y7TUQ@public.gmane.org>,
Senthil Balasubramanian
<senthilkumar-DlyHzToyqoxBDgjK7y7TUQ@public.gmane.org>,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
ath5k-devel-xDcbHBWguxEUs3QNXV6qNA@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"John W. Linville"
<linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
ath9k-devel-xDcbHBWguxHbcTqmT+pZeQ@public.gmane.org
Subject: Re: [ath9k-devel] [PATCH 2/2] ath: Fix logging message typos
Date: Wed, 01 Dec 2010 21:34:47 -0800 [thread overview]
Message-ID: <1291268087.1761.3.camel@Joe-Laptop> (raw)
In-Reply-To: <20101202053055.19479.qmail-Y+HMSxxDrH8@public.gmane.org>
On Thu, 2010-12-02 at 06:30 +0100, Peter Stuge wrote:
> Joe Perches wrote:
> > +++ b/drivers/net/wireless/ath/ath9k/ar9002_calib.c
> ..
> > @@ -734,7 +734,7 @@ static bool ar9285_hw_cl_cal(struct ath_hw *ah, struct ath9k_channel *chan)
> > if (!ath9k_hw_wait(ah, AR_PHY_AGC_CONTROL, AR_PHY_AGC_CONTROL_CAL,
> > 0, AH_WAIT_TIMEOUT)) {
> > ath_dbg(common, ATH_DBG_CALIBRATE,
> > - "offset calibration failed to complete in 1ms; noisy ??\n");
> > + "offset calibration failed to complete in 1ms; noisy enfironment?\n");
>
> enfironment? :)
Umm, what's a typo fix patch without more typos?
Correct? How dull...
> > ath_dbg(common, ATH_DBG_ANI,
> > - "Getting spur idx %d is2Ghz. %d val %x\n",
> > + "Getting spur idx:%d is2Ghz:%d val:%x\n",
> > i, is2GHz, ah->config.spurchans[i][is2GHz]);
>
> Is this short for "spurious" ?
Likely. Anyone want to change it to a whole word?
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-12-02 5:34 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 5:13 [ath9k-devel] [PATCH 1/2] ath: Fix ath_dbg uses missing newlines and access beyond array bound Joe Perches
2010-12-02 5:13 ` Joe Perches
2010-12-02 5:13 ` Joe Perches
2010-12-02 5:13 ` [ath9k-devel] [PATCH 2/2] ath: Fix logging message typos Joe Perches
2010-12-02 5:13 ` Joe Perches
2010-12-02 5:13 ` Joe Perches
2010-12-02 5:13 ` Joe Perches
2010-12-02 5:30 ` [ath9k-devel] " Peter Stuge
2010-12-02 5:30 ` Peter Stuge
2010-12-02 5:30 ` [ath9k-devel] " Peter Stuge
2010-12-02 5:30 ` Peter Stuge
2010-12-02 5:34 ` Joe Perches [this message]
2010-12-02 5:34 ` Joe Perches
2010-12-02 5:34 ` Joe Perches
2010-12-02 5:34 ` Joe Perches
2010-12-02 6:01 ` Nick Kossifidis
2010-12-02 6:01 ` Nick Kossifidis
2010-12-02 6:01 ` [ath9k-devel] " Nick Kossifidis
2010-12-02 6:01 ` Nick Kossifidis
2010-12-02 5:35 ` [ath9k-devel] [PATCH 2/2 V2] " Joe Perches
2010-12-02 5:35 ` Joe Perches
2010-12-02 5:35 ` Joe Perches
2010-12-02 5:35 ` Joe Perches
2010-12-02 19:02 ` [ath9k-devel] [PATCH 1/2] ath: Fix ath_dbg uses missing newlines and access beyond array bound Luis R. Rodriguez
2010-12-02 19:02 ` Luis R. Rodriguez
2010-12-02 19:02 ` Luis R. Rodriguez
2010-12-03 3:12 ` [ath9k-devel] [PATCH 0/4] ath: logging message conversion Joe Perches
2010-12-03 3:12 ` Joe Perches
2010-12-03 3:12 ` Joe Perches
2010-12-03 3:12 ` [PATCH 1/4] ath: Add and use ath_printk and ath_<level> Joe Perches
2010-12-07 21:38 ` John W. Linville
2010-12-07 19:05 ` [ath9k-devel] [PATCH 0/4] ath: logging message conversion John W. Linville
2010-12-07 19:05 ` John W. Linville
2010-12-07 19:05 ` John W. Linville
2010-12-07 19:26 ` [ath9k-devel] " Luis R. Rodriguez
2010-12-07 19:26 ` Luis R. Rodriguez
2010-12-03 3:12 ` [ath9k-devel] [PATCH 2/4] ath: Convert ath_print(.., ATH_DBG_FATAL to ath_err Joe Perches
2010-12-03 3:12 ` Joe Perches
2010-12-03 3:12 ` Joe Perches
2010-12-03 3:12 ` Joe Perches
2010-12-03 3:12 ` [ath9k-devel] [PATCH 3/4] ath: Convert ath_print to ath_dbg Joe Perches
2010-12-03 3:12 ` Joe Perches
2010-12-03 3:12 ` Joe Perches
2010-12-03 3:12 ` Joe Perches
2010-12-03 3:12 ` [ath9k-devel] [PATCH 4/4] ath: Fix ath_dbg access beyond array bound Joe Perches
2010-12-03 3:12 ` Joe Perches
2010-12-03 3:12 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291268087.1761.3.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.