From: Lin Ming <ming.m.lin@intel.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>,
Andi Kleen <andi@firstfloor.org>, Ingo Molnar <mingo@elte.hu>,
Frederic Weisbecker <fweisbec@gmail.com>,
Arjan van de Ven <arjan@infradead.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 2/3 v3] perf: Implement Nehalem uncore pmu
Date: Thu, 02 Dec 2010 13:57:46 +0800 [thread overview]
Message-ID: <1291269466.2405.322.camel@minggr.sh.intel.com> (raw)
In-Reply-To: <1291267223.2405.314.camel@minggr.sh.intel.com>
On Thu, 2010-12-02 at 13:20 +0800, Lin Ming wrote:
> Changelogs of v3:
>
> - Allocate uncore data with kmalloc_node, like AMD NB stuff. (Peter
> Zijlstra)
>
> - per-task uncore event is not allowed. Simply set pmu::task_ctx_nr =
> perf_invalid_context. (Peter Zijlstra)
<snip>
> +
> +static struct pmu uncore_pmu = {
> + .event_init = uncore_pmu_event_init,
> + .add = uncore_pmu_add,
> + .del = uncore_pmu_del,
> + .start = uncore_pmu_start,
> + .stop = uncore_pmu_stop,
> + .read = uncore_pmu_read,
> +};
Sorry, I send out an old version, need below additional code to disallow
per-task uncore event.
diff --git a/arch/x86/kernel/cpu/perf_event_intel_uncore.c b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
index d2c10d8..d2a22ba 100644
--- a/arch/x86/kernel/cpu/perf_event_intel_uncore.c
+++ b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
@@ -252,6 +252,8 @@ static void uncore_pmu_read(struct perf_event *event)
}
static struct pmu uncore_pmu = {
+ .task_ctx_nr = perf_invalid_context, /* per-task uncore event is not allowed */
+
.event_init = uncore_pmu_event_init,
.add = uncore_pmu_add,
.del = uncore_pmu_del,
next prev parent reply other threads:[~2010-12-02 5:55 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 5:20 [RFC PATCH 2/3 v3] perf: Implement Nehalem uncore pmu Lin Ming
2010-12-02 5:57 ` Lin Ming [this message]
2010-12-07 6:15 ` Lin Ming
2010-12-09 19:17 ` Peter Zijlstra
2010-12-09 19:21 ` Peter Zijlstra
2010-12-09 20:15 ` Stephane Eranian
2010-12-09 20:19 ` Peter Zijlstra
2010-12-09 20:27 ` Stephane Eranian
2010-12-09 23:46 ` Stephane Eranian
2010-12-10 8:31 ` Lin Ming
2010-12-10 10:47 ` Peter Zijlstra
2010-12-10 10:52 ` Peter Zijlstra
2010-12-10 15:11 ` Cyrill Gorcunov
2010-12-11 5:49 ` Stephane Eranian
2010-12-13 8:27 ` Lin Ming
2010-12-13 16:42 ` Stephane Eranian
2010-12-13 16:51 ` Andi Kleen
2010-12-13 19:04 ` Stephane Eranian
2010-12-10 8:28 ` Lin Ming
2010-12-09 19:24 ` Peter Zijlstra
2010-12-10 8:28 ` Lin Ming
2011-01-13 17:14 ` Stephane Eranian
2011-01-17 1:29 ` Lin Ming
2011-01-17 8:44 ` Stephane Eranian
2011-01-17 10:51 ` Lin Ming
2011-01-17 10:56 ` Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291269466.2405.322.camel@minggr.sh.intel.com \
--to=ming.m.lin@intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=andi@firstfloor.org \
--cc=arjan@infradead.org \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.