* [PATCH] ASoC: omap: N810: Don't select CONFIG_OMAP_MUX but make it as dependency
@ 2010-12-01 9:01 Jarkko Nikula
2010-12-01 11:28 ` Mark Brown
2010-12-02 11:50 ` Liam Girdwood
0 siblings, 2 replies; 4+ messages in thread
From: Jarkko Nikula @ 2010-12-01 9:01 UTC (permalink / raw)
To: alsa-devel; +Cc: Tony Lindgren, Mark Brown, Liam Girdwood
Not all omap boards use kernel based pin multiplexing so
CONFIG_SND_OMAP_SOC_N810 should not select it by default as it can make
harm to other boards in multi-board kernels.
Therefore put CONFIG_OMAP_MUX as a dependency to N810 ASoC machine driver.
Thanks to Tony Lindgren <tony@atomide.com> for noticing.
Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
Cc: Tony Lindgren <tony@atomide.com>
---
sound/soc/omap/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/omap/Kconfig b/sound/soc/omap/Kconfig
index d542ea2..a088db6 100644
--- a/sound/soc/omap/Kconfig
+++ b/sound/soc/omap/Kconfig
@@ -12,8 +12,8 @@ config SND_OMAP_SOC_MCPDM
config SND_OMAP_SOC_N810
tristate "SoC Audio support for Nokia N810"
depends on SND_OMAP_SOC && MACH_NOKIA_N810 && I2C
+ depends on OMAP_MUX
select SND_OMAP_SOC_MCBSP
- select OMAP_MUX
select SND_SOC_TLV320AIC3X
help
Say Y if you want to add support for SoC audio on Nokia N810.
--
1.7.2.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: omap: N810: Don't select CONFIG_OMAP_MUX but make it as dependency
2010-12-01 9:01 [PATCH] ASoC: omap: N810: Don't select CONFIG_OMAP_MUX but make it as dependency Jarkko Nikula
@ 2010-12-01 11:28 ` Mark Brown
2010-12-01 15:49 ` Tony Lindgren
2010-12-02 11:50 ` Liam Girdwood
1 sibling, 1 reply; 4+ messages in thread
From: Mark Brown @ 2010-12-01 11:28 UTC (permalink / raw)
To: Jarkko Nikula; +Cc: Tony Lindgren, alsa-devel, Liam Girdwood
On Wed, Dec 01, 2010 at 11:01:20AM +0200, Jarkko Nikula wrote:
> Not all omap boards use kernel based pin multiplexing so
> CONFIG_SND_OMAP_SOC_N810 should not select it by default as it can make
> harm to other boards in multi-board kernels.
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: omap: N810: Don't select CONFIG_OMAP_MUX but make it as dependency
2010-12-01 11:28 ` Mark Brown
@ 2010-12-01 15:49 ` Tony Lindgren
0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2010-12-01 15:49 UTC (permalink / raw)
To: Mark Brown; +Cc: alsa-devel, Liam Girdwood
* Mark Brown <broonie@opensource.wolfsonmicro.com> [101201 03:19]:
> On Wed, Dec 01, 2010 at 11:01:20AM +0200, Jarkko Nikula wrote:
> > Not all omap boards use kernel based pin multiplexing so
> > CONFIG_SND_OMAP_SOC_N810 should not select it by default as it can make
> > harm to other boards in multi-board kernels.
>
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Jarkko thanks for fixing this:
Acked-by: Tony Lindgren <tony@atomide.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: omap: N810: Don't select CONFIG_OMAP_MUX but make it as dependency
2010-12-01 9:01 [PATCH] ASoC: omap: N810: Don't select CONFIG_OMAP_MUX but make it as dependency Jarkko Nikula
2010-12-01 11:28 ` Mark Brown
@ 2010-12-02 11:50 ` Liam Girdwood
1 sibling, 0 replies; 4+ messages in thread
From: Liam Girdwood @ 2010-12-02 11:50 UTC (permalink / raw)
To: Jarkko Nikula; +Cc: Tony Lindgren, alsa-devel, Brown, Mark
On Wed, 2010-12-01 at 11:01 +0200, Jarkko Nikula wrote:
> Not all omap boards use kernel based pin multiplexing so
> CONFIG_SND_OMAP_SOC_N810 should not select it by default as it can make
> harm to other boards in multi-board kernels.
>
> Therefore put CONFIG_OMAP_MUX as a dependency to N810 ASoC machine driver.
>
> Thanks to Tony Lindgren <tony@atomide.com> for noticing.
>
> Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
> Cc: Tony Lindgren <tony@atomide.com>
> ---
Applied.
Thanks
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-12-02 11:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-01 9:01 [PATCH] ASoC: omap: N810: Don't select CONFIG_OMAP_MUX but make it as dependency Jarkko Nikula
2010-12-01 11:28 ` Mark Brown
2010-12-01 15:49 ` Tony Lindgren
2010-12-02 11:50 ` Liam Girdwood
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.