Re: [PATCH 2/3] nl80211: Export available antennas

[Johannes Berg <johannes@sipsolutions.net>]

On Mon, 2010-12-06 at 17:30 +0900, Bruno Randolf wrote:
> On Mon December 6 2010 17:17:33 Johannes Berg wrote:
> > On Mon, 2010-12-06 at 12:45 +0900, Bruno Randolf wrote:
> > > +		NLA_PUT_U32(msg, NL80211_ATTR_WIPHY_ANTENNA_AVAIL,
> > > +			    dev->wiphy.available_antennas);
> > 
> > I think you should not advertise this unless it's non-zero, and unless
> > also the set/get callbacks are available.
> 
> I don't. Please check the context of this patch, esp patch 1. of this series.

Ah, indeed, the context overlap was lost on me.

> > Similarly, I think you shouldn't advertise the set/get CMDs when the
> > available antennas aren't set.
> 
> There are no set/get commands for antennas since you preferred putting it into 
> wiphy info.

Oops. Forgot all about that, sorry!

> > Finally, you should check for nl80211 that the given tx/rx masks fall
> > into the available antennas mask.
> 
> Allright, I can do that. Would you prefer to reject the command in this case 
> or just apply the available mask?

I'd reject it, since userspace could have checked whether it was valid.

johannes