Re: [PATCH] ASoC: dapm: Add speaker driver widget.

[Liam Girdwood <lrg@slimlogic.co.uk>]

On Mon, 2010-12-06 at 22:43 +0000, Mark Brown wrote:
> On Mon, Dec 06, 2010 at 04:34:37PM -0600, Olaya, Margarita wrote:
> 
> > In some cases it was not possible to follow the appropiate power
> > ON/OFF sequence.
> > Add a widget to support speaker drivers where power ON/OFF
> > ordering is important.
> 
> Why not use the existing speaker widget?  It's at pretty much the same
> point in the sequence and is intended for use with external GPIO
> controlled speaker drivers.  It'd be good to discuss this in the
> changelog.
> 

In this case the driver block is on the CODEC IC and after the PGA in
the audio output path, hence this version is better suited than the
external GPIO version.

> > +#define SND_SOC_DAPM_DRV(wname, wreg, wshift, winvert,\
> > +	 wcontrols, wncontrols) \
> > +{	.id = snd_soc_dapm_drv, .name = wname, .reg = wreg, .shift = wshift, \
> > +	.invert = winvert, .kcontrols = wcontrols, .num_kcontrols = wncontrols}
> 
> The _DRV name seems rather opaque - I'd suggest _SPK as a name but
> obviously that's in use.  If we do want this I guess _SPK_DRV or
> sommething.

I was thinking this too, but then I thought we may want to drive other
loads than just speakers here. e.g. haptic, vibra

Liam

-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk