From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "Olaya, Margarita" <magi.olaya@ti.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] ASoC: dapm: Add speaker driver widget.
Date: Tue, 07 Dec 2010 12:46:28 +0000 [thread overview]
Message-ID: <1291725988.3275.22.camel@odin> (raw)
In-Reply-To: <20101207123600.GD4698@rakim.wolfsonmicro.main>
On Tue, 2010-12-07 at 12:36 +0000, Mark Brown wrote:
> On Tue, Dec 07, 2010 at 12:34:45PM +0000, Liam Girdwood wrote:
> > On Mon, 2010-12-06 at 23:38 +0000, Mark Brown wrote:
>
> > > ...we don't need to change the ordering at all, we've already got a
> > > sequence point for this sort of widget we can use. We should just make
> > > the existing speaker and headphone widgets be in terms of one, I think.
>
> > The only minor problem here is that the current sequence point is name
> > "snd_soc_dapm_spk" which would seem confusing to haptic/vibra driver
> > users. Although, I can live with this....
>
> I meant the number in the sequence - the patch had the new widget coming
> up in the slot before the existing output driver widgets.
Ok, but by sharing the number we take away some flexibility in the
sequence ordering. Say something has to be done in the machine driver
_after_ the spk/haptic/vibra driver is enabled in the CODEC driver ?
I dont actually see any major issue of using a new number here unless
you have it reserved for something else ?
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2010-12-07 12:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 22:34 [PATCH] ASoC: dapm: Add speaker driver widget Olaya, Margarita
2010-12-06 22:43 ` Mark Brown
2010-12-06 22:55 ` Liam Girdwood
2010-12-06 23:09 ` Mark Brown
2010-12-06 23:30 ` Liam Girdwood
2010-12-06 23:38 ` Mark Brown
2010-12-07 12:34 ` Liam Girdwood
2010-12-07 12:36 ` Mark Brown
2010-12-07 12:46 ` Liam Girdwood [this message]
2010-12-07 13:09 ` Mark Brown
2010-12-07 14:01 ` Liam Girdwood
2010-12-07 14:13 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291725988.3275.22.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=magi.olaya@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.