* [PATCH] ASoC: WM8580: Fix R8 initial value
@ 2010-12-09 9:07 Jassi Brar
2010-12-09 10:09 ` Liam Girdwood
2010-12-09 11:00 ` Mark Brown
0 siblings, 2 replies; 4+ messages in thread
From: Jassi Brar @ 2010-12-09 9:07 UTC (permalink / raw)
To: alsa-devel; +Cc: sbkim73, kgene.kim, broonie, sw.youn, lrg
From: Seungwhan Youn <sw.youn@samsung.com>
Acc to WM8580 manual, the default value for R8 is 0x10, not 0x1c.
Signed-off-by: Seungwhan Youn <sw.youn@samsung.com>
---
sound/soc/codecs/wm8580.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/wm8580.c b/sound/soc/codecs/wm8580.c
index 6e95332..6be373d 100644
--- a/sound/soc/codecs/wm8580.c
+++ b/sound/soc/codecs/wm8580.c
@@ -179,7 +179,7 @@
static const u16 wm8580_reg[] = {
0x0121, 0x017e, 0x007d, 0x0014, /*R3*/
0x0121, 0x017e, 0x007d, 0x0194, /*R7*/
- 0x001c, 0x0002, 0x0002, 0x00c2, /*R11*/
+ 0x0010, 0x0002, 0x0002, 0x00c2, /*R11*/
0x0182, 0x0082, 0x000a, 0x0024, /*R15*/
0x0009, 0x0000, 0x00ff, 0x0000, /*R19*/
0x00ff, 0x00ff, 0x00ff, 0x00ff, /*R23*/
--
1.6.2.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: WM8580: Fix R8 initial value
2010-12-09 9:07 [PATCH] ASoC: WM8580: Fix R8 initial value Jassi Brar
@ 2010-12-09 10:09 ` Liam Girdwood
2010-12-09 11:00 ` Mark Brown
1 sibling, 0 replies; 4+ messages in thread
From: Liam Girdwood @ 2010-12-09 10:09 UTC (permalink / raw)
To: Jassi Brar; +Cc: sbkim73, sw.youn, alsa-devel, kgene.kim, broonie
On Thu, 2010-12-09 at 18:07 +0900, Jassi Brar wrote:
> From: Seungwhan Youn <sw.youn@samsung.com>
>
> Acc to WM8580 manual, the default value for R8 is 0x10, not 0x1c.
>
> Signed-off-by: Seungwhan Youn <sw.youn@samsung.com>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: WM8580: Fix R8 initial value
2010-12-09 9:07 [PATCH] ASoC: WM8580: Fix R8 initial value Jassi Brar
2010-12-09 10:09 ` Liam Girdwood
@ 2010-12-09 11:00 ` Mark Brown
2010-12-09 11:50 ` Jassi Brar
1 sibling, 1 reply; 4+ messages in thread
From: Mark Brown @ 2010-12-09 11:00 UTC (permalink / raw)
To: Jassi Brar; +Cc: sbkim73, sw.youn, alsa-devel, kgene.kim, lrg
On Thu, Dec 09, 2010 at 06:07:52PM +0900, Jassi Brar wrote:
> From: Seungwhan Youn <sw.youn@samsung.com>
>
> Acc to WM8580 manual, the default value for R8 is 0x10, not 0x1c.
>
> Signed-off-by: Seungwhan Youn <sw.youn@samsung.com>
> ---
You really should include your signoff in patches when sending ones
written by other people to say that you're certifying that the patch is
legally OK to submit - that's what the signoff stuff is about, it's
about saying that you take responsibility for the patch.
In this case it's not so important as it's a trivially obvious fix so
probably below the individually copyrightable threashold anyway so I've
applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: WM8580: Fix R8 initial value
2010-12-09 11:00 ` Mark Brown
@ 2010-12-09 11:50 ` Jassi Brar
0 siblings, 0 replies; 4+ messages in thread
From: Jassi Brar @ 2010-12-09 11:50 UTC (permalink / raw)
To: Mark Brown; +Cc: alsa-devel, kgene.kim, Jassi Brar, sbkim73, sw.youn, lrg
On Thu, Dec 9, 2010 at 8:00 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Thu, Dec 09, 2010 at 06:07:52PM +0900, Jassi Brar wrote:
>> From: Seungwhan Youn <sw.youn@samsung.com>
>>
>> Acc to WM8580 manual, the default value for R8 is 0x10, not 0x1c.
>>
>> Signed-off-by: Seungwhan Youn <sw.youn@samsung.com>
>> ---
>
> You really should include your signoff in patches when sending ones
> written by other people to say that you're certifying that the patch is
> legally OK to submit - that's what the signoff stuff is about, it's
> about saying that you take responsibility for the patch.
Ok, will take care in future.
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-12-09 11:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-09 9:07 [PATCH] ASoC: WM8580: Fix R8 initial value Jassi Brar
2010-12-09 10:09 ` Liam Girdwood
2010-12-09 11:00 ` Mark Brown
2010-12-09 11:50 ` Jassi Brar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.