All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 01/14] block: Make bdrv_create_file() ':' handling consistent
Date: Thu,  9 Dec 2010 12:09:57 +0100	[thread overview]
Message-ID: <1291893010-29223-2-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1291893010-29223-1-git-send-email-kwolf@redhat.com>

From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

Filenames may start with "<protocol>:" to explicitly use a protocol like
nbd.  Filenames with unknown protocols are rejected in most of QEMU
except for bdrv_create_file().  Even if a file with an invalid filename
can be created, QEMU cannot use it since all the other relevant
functions reject such paths.  Make bdrv_create_file() consistent.

Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/block.c b/block.c
index 63effd8..e7a986c 100644
--- a/block.c
+++ b/block.c
@@ -215,7 +215,7 @@ int bdrv_create_file(const char* filename, QEMUOptionParameter *options)
 
     drv = bdrv_find_protocol(filename);
     if (drv == NULL) {
-        drv = bdrv_find_format("file");
+        return -ENOENT;
     }
 
     return bdrv_create(drv, filename, options);
-- 
1.7.2.3

  reply	other threads:[~2010-12-09 11:09 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-09 11:09 [Qemu-devel] [PULL 00/14] Block patches Kevin Wolf
2010-12-09 11:09 ` Kevin Wolf [this message]
2010-12-09 11:09 ` [Qemu-devel] [PATCH 02/14] Add missing tracing to qemu_mallocz() Kevin Wolf
2010-12-09 11:09 ` [Qemu-devel] [PATCH 03/14] Use qemu_mallocz() instead of calloc() in img_convert() Kevin Wolf
2010-12-09 11:10 ` [Qemu-devel] [PATCH 04/14] img_convert(): Only try to free bs[] entries if bs is valid Kevin Wolf
2010-12-09 11:10 ` [Qemu-devel] [PATCH 05/14] Consolidate printing of block driver options Kevin Wolf
2010-12-09 11:10 ` [Qemu-devel] [PATCH 06/14] Fix formatting and missing braces in qemu-img.c Kevin Wolf
2010-12-09 11:10 ` [Qemu-devel] [PATCH 07/14] Fail if detecting an unknown option Kevin Wolf
2010-12-09 11:10 ` [Qemu-devel] [PATCH 08/14] Make error handling more consistent in img_create() and img_resize() Kevin Wolf
2010-12-09 11:10 ` [Qemu-devel] [PATCH 09/14] ceph/rbd block driver for qemu-kvm Kevin Wolf
2010-12-09 11:10 ` [Qemu-devel] [PATCH 10/14] qemu-img: Deprecate obsolete -6 and -e options Kevin Wolf
2010-12-09 11:10 ` [Qemu-devel] [PATCH 11/14] qemu-option: Don't reinvent append_option_parameters() Kevin Wolf
2010-12-09 11:10 ` [Qemu-devel] [PATCH 12/14] qemu-option: Fix parse_option_parameters() documentation typo Kevin Wolf
2010-12-09 11:10 ` [Qemu-devel] [PATCH 13/14] qemu-img: Free option parameter lists in img_create() Kevin Wolf
2010-12-09 11:10 ` [Qemu-devel] [PATCH 14/14] qemu-img: Fail creation if backing format is invalid Kevin Wolf
2010-12-15 15:56 ` [Qemu-devel] Re: [PULL 00/14] Block patches Kevin Wolf
2010-12-17 14:48 ` [Qemu-devel] " Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1291893010-29223-2-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.