All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 07/14] Fail if detecting an unknown option
Date: Thu,  9 Dec 2010 12:10:03 +0100	[thread overview]
Message-ID: <1291893010-29223-8-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1291893010-29223-1-git-send-email-kwolf@redhat.com>

From: Jes Sorensen <Jes.Sorensen@redhat.com>

This patch changes qemu-img to exit if an unknown option is detected,
instead of trying to continue with a set of arguments which may be
incorrect.

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 qemu-img.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/qemu-img.c b/qemu-img.c
index cc77048..6fd52e9 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -309,6 +309,7 @@ static int img_create(int argc, char **argv)
             break;
         }
         switch(c) {
+        case '?':
         case 'h':
             help();
             break;
@@ -477,6 +478,7 @@ static int img_check(int argc, char **argv)
             break;
         }
         switch(c) {
+        case '?':
         case 'h':
             help();
             break;
@@ -555,6 +557,7 @@ static int img_commit(int argc, char **argv)
             break;
         }
         switch(c) {
+        case '?':
         case 'h':
             help();
             break;
@@ -693,6 +696,7 @@ static int img_convert(int argc, char **argv)
             break;
         }
         switch(c) {
+        case '?':
         case 'h':
             help();
             break;
@@ -1097,6 +1101,7 @@ static int img_info(int argc, char **argv)
             break;
         }
         switch(c) {
+        case '?':
         case 'h':
             help();
             break;
@@ -1174,6 +1179,7 @@ static int img_snapshot(int argc, char **argv)
             break;
         }
         switch(c) {
+        case '?':
         case 'h':
             help();
             return 0;
@@ -1289,6 +1295,7 @@ static int img_rebase(int argc, char **argv)
             break;
         }
         switch(c) {
+        case '?':
         case 'h':
             help();
             return 0;
@@ -1503,6 +1510,7 @@ static int img_resize(int argc, char **argv)
             break;
         }
         switch(c) {
+        case '?':
         case 'h':
             help();
             break;
-- 
1.7.2.3

  parent reply	other threads:[~2010-12-09 11:09 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-09 11:09 [Qemu-devel] [PULL 00/14] Block patches Kevin Wolf
2010-12-09 11:09 ` [Qemu-devel] [PATCH 01/14] block: Make bdrv_create_file() ':' handling consistent Kevin Wolf
2010-12-09 11:09 ` [Qemu-devel] [PATCH 02/14] Add missing tracing to qemu_mallocz() Kevin Wolf
2010-12-09 11:09 ` [Qemu-devel] [PATCH 03/14] Use qemu_mallocz() instead of calloc() in img_convert() Kevin Wolf
2010-12-09 11:10 ` [Qemu-devel] [PATCH 04/14] img_convert(): Only try to free bs[] entries if bs is valid Kevin Wolf
2010-12-09 11:10 ` [Qemu-devel] [PATCH 05/14] Consolidate printing of block driver options Kevin Wolf
2010-12-09 11:10 ` [Qemu-devel] [PATCH 06/14] Fix formatting and missing braces in qemu-img.c Kevin Wolf
2010-12-09 11:10 ` Kevin Wolf [this message]
2010-12-09 11:10 ` [Qemu-devel] [PATCH 08/14] Make error handling more consistent in img_create() and img_resize() Kevin Wolf
2010-12-09 11:10 ` [Qemu-devel] [PATCH 09/14] ceph/rbd block driver for qemu-kvm Kevin Wolf
2010-12-09 11:10 ` [Qemu-devel] [PATCH 10/14] qemu-img: Deprecate obsolete -6 and -e options Kevin Wolf
2010-12-09 11:10 ` [Qemu-devel] [PATCH 11/14] qemu-option: Don't reinvent append_option_parameters() Kevin Wolf
2010-12-09 11:10 ` [Qemu-devel] [PATCH 12/14] qemu-option: Fix parse_option_parameters() documentation typo Kevin Wolf
2010-12-09 11:10 ` [Qemu-devel] [PATCH 13/14] qemu-img: Free option parameter lists in img_create() Kevin Wolf
2010-12-09 11:10 ` [Qemu-devel] [PATCH 14/14] qemu-img: Fail creation if backing format is invalid Kevin Wolf
2010-12-15 15:56 ` [Qemu-devel] Re: [PULL 00/14] Block patches Kevin Wolf
2010-12-17 14:48 ` [Qemu-devel] " Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1291893010-29223-8-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.