From: "Michael Büsch" <mb@bu3sch.de>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
b43-dev@lists.infradead.org
Subject: [PATCH 2/4] b43: set TMS to work with current band width for N-PHY
Date: Thu, 09 Dec 2010 15:41:44 +0100 [thread overview]
Message-ID: <1291905704.2905.9.camel@maggie> (raw)
In-Reply-To: <AANLkTinJUsKzNO6vO8F9KupxF0uc1h97wffhAgBas1Pe@mail.gmail.com> (sfid-20101209_152344_283295_FFFFFFFFF86E6A27)
On Thu, 2010-12-09 at 15:23 +0100, Rafa? Mi?ecki wrote:
> W dniu 9 grudnia 2010 15:19 u?ytkownik Michael B?sch <mb@bu3sch.de> napisa?:
> > On Thu, 2010-12-09 at 15:13 +0100, Rafa? Mi?ecki wrote:
> >> W dniu 9 grudnia 2010 15:12 u?ytkownik Rafa? Mi?ecki <zajec5@gmail.com> napisa?:
> >> > W dniu 7 grudnia 2010 22:08 u?ytkownik Michael B?sch <mb@bu3sch.de> napisa?:
> >> >> On Tue, 2010-12-07 at 21:55 +0100, Rafa? Mi?ecki wrote:
> >> >>> Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com>
> >> >>> ---
> >> >>> drivers/net/wireless/b43/main.c | 6 ++++++
> >> >>> drivers/net/wireless/b43/phy_common.c | 7 +++++++
> >> >>> drivers/net/wireless/b43/phy_common.h | 2 ++
> >> >>> drivers/net/wireless/b43/phy_n.c | 7 -------
> >> >>> 4 files changed, 15 insertions(+), 7 deletions(-)
> >> >>>
> >> >>> diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
> >> >>> index fa48803..670fd7b 100644
> >> >>> --- a/drivers/net/wireless/b43/main.c
> >> >>> +++ b/drivers/net/wireless/b43/main.c
> >> >>> @@ -1150,6 +1150,12 @@ void b43_wireless_core_reset(struct b43_wldev *dev, u32 flags)
> >> >>>
> >> >>> flags |= B43_TMSLOW_PHYCLKEN;
> >> >>> flags |= B43_TMSLOW_PHYRESET;
> >> >>> + if (dev->phy.type == B43_PHYTYPE_N) {
> >> >>> + if (b43_channel_type_is_40mhz(dev->phy.channel_type))
> >> >>
> >> >> Is channel_type already set at this time?
The more I think about this, the wronger it looks to me.
Why do we care about the channel type at reset time anyway?
I guess the channel type is a parameter that can change any time on an
operating card. So just unconditionally set B43_TMSLOW_PHYCLKSPEED_80MHZ
at reset time and set the correct TMSLOW bits later when channel_type is
actually changed. That seems to be the only sane thing to do.
I guess we don't want to fully reset the device when channel_type
changes, do we?
--
Greetings Michael.
WARNING: multiple messages have this Message-ID (diff)
From: "Michael Büsch" <mb@bu3sch.de>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
b43-dev@lists.infradead.org
Subject: Re: [PATCH 2/4] b43: set TMS to work with current band width for N-PHY
Date: Thu, 09 Dec 2010 15:41:44 +0100 [thread overview]
Message-ID: <1291905704.2905.9.camel@maggie> (raw)
In-Reply-To: <AANLkTinJUsKzNO6vO8F9KupxF0uc1h97wffhAgBas1Pe@mail.gmail.com> (sfid-20101209_152344_283295_FFFFFFFFF86E6A27)
On Thu, 2010-12-09 at 15:23 +0100, Rafał Miłecki wrote:
> W dniu 9 grudnia 2010 15:19 użytkownik Michael Büsch <mb@bu3sch.de> napisał:
> > On Thu, 2010-12-09 at 15:13 +0100, Rafał Miłecki wrote:
> >> W dniu 9 grudnia 2010 15:12 użytkownik Rafał Miłecki <zajec5@gmail.com> napisał:
> >> > W dniu 7 grudnia 2010 22:08 użytkownik Michael Büsch <mb@bu3sch.de> napisał:
> >> >> On Tue, 2010-12-07 at 21:55 +0100, Rafał Miłecki wrote:
> >> >>> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> >> >>> ---
> >> >>> drivers/net/wireless/b43/main.c | 6 ++++++
> >> >>> drivers/net/wireless/b43/phy_common.c | 7 +++++++
> >> >>> drivers/net/wireless/b43/phy_common.h | 2 ++
> >> >>> drivers/net/wireless/b43/phy_n.c | 7 -------
> >> >>> 4 files changed, 15 insertions(+), 7 deletions(-)
> >> >>>
> >> >>> diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
> >> >>> index fa48803..670fd7b 100644
> >> >>> --- a/drivers/net/wireless/b43/main.c
> >> >>> +++ b/drivers/net/wireless/b43/main.c
> >> >>> @@ -1150,6 +1150,12 @@ void b43_wireless_core_reset(struct b43_wldev *dev, u32 flags)
> >> >>>
> >> >>> flags |= B43_TMSLOW_PHYCLKEN;
> >> >>> flags |= B43_TMSLOW_PHYRESET;
> >> >>> + if (dev->phy.type == B43_PHYTYPE_N) {
> >> >>> + if (b43_channel_type_is_40mhz(dev->phy.channel_type))
> >> >>
> >> >> Is channel_type already set at this time?
The more I think about this, the wronger it looks to me.
Why do we care about the channel type at reset time anyway?
I guess the channel type is a parameter that can change any time on an
operating card. So just unconditionally set B43_TMSLOW_PHYCLKSPEED_80MHZ
at reset time and set the correct TMSLOW bits later when channel_type is
actually changed. That seems to be the only sane thing to do.
I guess we don't want to fully reset the device when channel_type
changes, do we?
--
Greetings Michael.
next prev parent reply other threads:[~2010-12-09 14:41 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-07 20:55 [PATCH 0/4] Make N-PHY support experimental Rafał Miłecki
2010-12-07 20:55 ` Rafał Miłecki
2010-12-07 20:55 ` [PATCH 1/4] b43: N-PHY: silence warnings Rafał Miłecki
2010-12-07 20:55 ` Rafał Miłecki
2010-12-07 20:55 ` [PATCH 2/4] b43: set TMS to work with current band width for N-PHY Rafał Miłecki
2010-12-07 20:55 ` Rafał Miłecki
2010-12-07 21:08 ` Michael Büsch
2010-12-07 21:08 ` Michael Büsch
2010-12-09 14:12 ` Rafał Miłecki
2010-12-09 14:12 ` Rafał Miłecki
2010-12-09 14:13 ` Rafał Miłecki
2010-12-09 14:13 ` Rafał Miłecki
2010-12-09 14:19 ` Michael Büsch
2010-12-09 14:19 ` Michael Büsch
2010-12-09 14:23 ` Rafał Miłecki
2010-12-09 14:23 ` Rafał Miłecki
2010-12-09 14:28 ` Michael Büsch
2010-12-09 14:28 ` Michael Büsch
2010-12-09 14:41 ` Michael Büsch [this message]
2010-12-09 14:41 ` Michael Büsch
2010-12-07 20:55 ` [PATCH 3/4] b43: fix split of N-PHY devices into supported and not (based on PHY rev) Rafał Miłecki
2010-12-07 20:55 ` Rafał Miłecki
2010-12-07 20:56 ` [PATCH 4/4] b43: rename config option for N-PHY, drop BROKEN Rafał Miłecki
2010-12-07 20:56 ` Rafał Miłecki
2010-12-07 21:04 ` [PATCH 0/4] Make N-PHY support experimental Johannes Berg
2010-12-07 21:04 ` Johannes Berg
2010-12-07 22:57 ` Gábor Stefanik
2010-12-07 22:57 ` Gábor Stefanik
2010-12-07 23:11 ` Larry Finger
2010-12-07 23:11 ` Larry Finger
2010-12-08 3:37 ` Larry Finger
2010-12-08 3:37 ` Larry Finger
2010-12-09 14:11 ` Rafał Miłecki
2010-12-09 14:11 ` Rafał Miłecki
2010-12-09 15:20 ` Larry Finger
2010-12-09 15:20 ` Larry Finger
2010-12-09 15:25 ` Johannes Berg
2010-12-09 15:25 ` Johannes Berg
2010-12-09 15:28 ` Rafał Miłecki
2010-12-09 15:28 ` Rafał Miłecki
2010-12-09 15:33 ` Johannes Berg
2010-12-09 15:33 ` Johannes Berg
2010-12-09 15:37 ` Rafał Miłecki
2010-12-09 15:37 ` Rafał Miłecki
2010-12-09 16:03 ` Larry Finger
2010-12-09 16:03 ` Larry Finger
2010-12-10 3:52 ` Jon Saul
2010-12-10 3:52 ` Jon Saul
2010-12-10 4:05 ` Larry Finger
2010-12-10 4:05 ` Larry Finger
2010-12-09 16:10 ` Rafał Miłecki
2010-12-09 16:10 ` Rafał Miłecki
2010-12-08 15:15 ` b43 N PHY status report Larry Finger
2010-12-08 15:15 ` Larry Finger
2010-12-10 16:57 ` Peter Stuge
2010-12-10 17:15 ` Larry Finger
2010-12-10 18:34 ` Peter Stuge
2010-12-10 18:44 ` Peter Stuge
2010-12-13 17:00 ` Rafał Miłecki
2010-12-13 17:41 ` Larry Finger
2010-12-13 18:17 ` Rafał Miłecki
2010-12-13 18:37 ` Larry Finger
2010-12-13 18:34 ` Peter Stuge
2010-12-13 18:43 ` Larry Finger
2010-12-10 18:22 ` Francesco Gringoli
2010-12-10 18:30 ` Francesco Gringoli
2010-12-10 18:30 ` Francesco Gringoli
2010-12-10 18:47 ` Johannes Berg
2010-12-10 18:47 ` Johannes Berg
2010-12-10 19:02 ` Larry Finger
2010-12-10 19:02 ` Larry Finger
2010-12-10 19:04 ` Gábor Stefanik
2010-12-10 19:04 ` Gábor Stefanik
2010-12-10 19:08 ` Johannes Berg
2010-12-10 19:08 ` Johannes Berg
2010-12-21 9:25 ` David Woodhouse
2010-12-21 9:25 ` David Woodhouse
2010-12-21 9:30 ` Rafał Miłecki
2010-12-21 9:30 ` Rafał Miłecki
2010-12-21 14:30 ` Larry Finger
2010-12-21 14:30 ` Larry Finger
2010-12-10 18:53 ` Konstantinos Karantias
2010-12-10 19:00 ` Larry Finger
2010-12-10 19:00 ` Larry Finger
2010-12-09 14:09 ` [PATCH 0/4] Make N-PHY support experimental Rafał Miłecki
2010-12-09 14:09 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291905704.2905.9.camel@maggie \
--to=mb@bu3sch.de \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.