From: Tomi Valkeinen <tomi.valkeinen@nokia.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: OMAP4 build error - omapfb
Date: Tue, 14 Dec 2010 12:44:22 +0000 [thread overview]
Message-ID: <1292330662.6893.115.camel@tubuntu> (raw)
In-Reply-To: <20101202220024.GX17222@atomide.com>
On Thu, 2010-12-02 at 14:00 -0800, ext Tony Lindgren wrote:
> * Russell King - ARM Linux <linux@arm.linux.org.uk> [101202 13:15]:
> > drivers/built-in.o: In function `omapfb_do_probe':
> > drivers/video/omap/omapfb_main.c:1773: undefined reference to `omap2_int_ctrl'
> >
> > Looks like there's a missing dependency for CONFIG_FB_OMAP. As the
> > only place omap2_int_ctrl is defined is in drivers/video/omap/dispc.c,
> > and this isn't built for OMAP4, maybe FB_OMAP is missing a dependency
> > such that it's only available for OMAP1, OMAP2 and OMAP3 ?
>
> This is something for Tomi, adding fbdev and Tomi to Cc.
Looks correct. The old omapfb will never work with OMAP4, so a
dependency to OMAP1/2/3 fixes the build problem. I'll add this fix to my
tree.
Tomi
>
> Tony
>
> > diff --git a/drivers/video/omap/Kconfig b/drivers/video/omap/Kconfig
> > index 455c605..083c8fe 100644
> > --- a/drivers/video/omap/Kconfig
> > +++ b/drivers/video/omap/Kconfig
> > @@ -1,7 +1,7 @@
> > config FB_OMAP
> > tristate "OMAP frame buffer support (EXPERIMENTAL)"
> > - depends on FB && ARCH_OMAP && (OMAP2_DSS = "n")
> > -
> > + depends on FB && (OMAP2_DSS = "n")
> > + depends on ARCH_OMAP1 || ARCH_OMAP2 || ARCH_OMAP3
> > select FB_CFB_FILLRECT
> > select FB_CFB_COPYAREA
> > select FB_CFB_IMAGEBLIT
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@nokia.com>
To: ext Tony Lindgren <tony@atomide.com>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-fbdev@vger.kernel.org
Subject: Re: OMAP4 build error - omapfb
Date: Tue, 14 Dec 2010 14:44:22 +0200 [thread overview]
Message-ID: <1292330662.6893.115.camel@tubuntu> (raw)
In-Reply-To: <20101202220024.GX17222@atomide.com>
On Thu, 2010-12-02 at 14:00 -0800, ext Tony Lindgren wrote:
> * Russell King - ARM Linux <linux@arm.linux.org.uk> [101202 13:15]:
> > drivers/built-in.o: In function `omapfb_do_probe':
> > drivers/video/omap/omapfb_main.c:1773: undefined reference to `omap2_int_ctrl'
> >
> > Looks like there's a missing dependency for CONFIG_FB_OMAP. As the
> > only place omap2_int_ctrl is defined is in drivers/video/omap/dispc.c,
> > and this isn't built for OMAP4, maybe FB_OMAP is missing a dependency
> > such that it's only available for OMAP1, OMAP2 and OMAP3 ?
>
> This is something for Tomi, adding fbdev and Tomi to Cc.
Looks correct. The old omapfb will never work with OMAP4, so a
dependency to OMAP1/2/3 fixes the build problem. I'll add this fix to my
tree.
Tomi
>
> Tony
>
> > diff --git a/drivers/video/omap/Kconfig b/drivers/video/omap/Kconfig
> > index 455c605..083c8fe 100644
> > --- a/drivers/video/omap/Kconfig
> > +++ b/drivers/video/omap/Kconfig
> > @@ -1,7 +1,7 @@
> > config FB_OMAP
> > tristate "OMAP frame buffer support (EXPERIMENTAL)"
> > - depends on FB && ARCH_OMAP && (OMAP2_DSS = "n")
> > -
> > + depends on FB && (OMAP2_DSS = "n")
> > + depends on ARCH_OMAP1 || ARCH_OMAP2 || ARCH_OMAP3
> > select FB_CFB_FILLRECT
> > select FB_CFB_COPYAREA
> > select FB_CFB_IMAGEBLIT
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: tomi.valkeinen@nokia.com (Tomi Valkeinen)
To: linux-arm-kernel@lists.infradead.org
Subject: OMAP4 build error - omapfb
Date: Tue, 14 Dec 2010 14:44:22 +0200 [thread overview]
Message-ID: <1292330662.6893.115.camel@tubuntu> (raw)
In-Reply-To: <20101202220024.GX17222@atomide.com>
On Thu, 2010-12-02 at 14:00 -0800, ext Tony Lindgren wrote:
> * Russell King - ARM Linux <linux@arm.linux.org.uk> [101202 13:15]:
> > drivers/built-in.o: In function `omapfb_do_probe':
> > drivers/video/omap/omapfb_main.c:1773: undefined reference to `omap2_int_ctrl'
> >
> > Looks like there's a missing dependency for CONFIG_FB_OMAP. As the
> > only place omap2_int_ctrl is defined is in drivers/video/omap/dispc.c,
> > and this isn't built for OMAP4, maybe FB_OMAP is missing a dependency
> > such that it's only available for OMAP1, OMAP2 and OMAP3 ?
>
> This is something for Tomi, adding fbdev and Tomi to Cc.
Looks correct. The old omapfb will never work with OMAP4, so a
dependency to OMAP1/2/3 fixes the build problem. I'll add this fix to my
tree.
Tomi
>
> Tony
>
> > diff --git a/drivers/video/omap/Kconfig b/drivers/video/omap/Kconfig
> > index 455c605..083c8fe 100644
> > --- a/drivers/video/omap/Kconfig
> > +++ b/drivers/video/omap/Kconfig
> > @@ -1,7 +1,7 @@
> > config FB_OMAP
> > tristate "OMAP frame buffer support (EXPERIMENTAL)"
> > - depends on FB && ARCH_OMAP && (OMAP2_DSS = "n")
> > -
> > + depends on FB && (OMAP2_DSS = "n")
> > + depends on ARCH_OMAP1 || ARCH_OMAP2 || ARCH_OMAP3
> > select FB_CFB_FILLRECT
> > select FB_CFB_COPYAREA
> > select FB_CFB_IMAGEBLIT
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo at vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-12-14 12:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 21:25 OMAP4 build error - omapfb Russell King - ARM Linux
2010-12-02 21:25 ` Russell King - ARM Linux
2010-12-02 22:00 ` Tony Lindgren
2010-12-02 22:00 ` Tony Lindgren
2010-12-02 22:00 ` Tony Lindgren
2010-12-14 12:44 ` Tomi Valkeinen [this message]
2010-12-14 12:44 ` Tomi Valkeinen
2010-12-14 12:44 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292330662.6893.115.camel@tubuntu \
--to=tomi.valkeinen@nokia.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.