From: Artem Bityutskiy <dedekind1@gmail.com>
To: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Cc: Tony Lindgren <tony@atomide.com>,
David Woodhouse <dwmw2@infradead.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] MTD: NAND: ams-delta: convert to platform driver
Date: Tue, 14 Dec 2010 19:00:23 +0200 [thread overview]
Message-ID: <1292346023.2538.103.camel@localhost> (raw)
In-Reply-To: <201012111840.05270.jkrzyszt@tis.icnet.pl>
On Sat, 2010-12-11 at 18:40 +0100, Janusz Krzysztofik wrote:
> In its current form, the driver may break unrelated machines if built into the
> kernel, hence is not suitable for inclusion into a kernel built for multiple
> OMAP1 machines. Convert it to a platform driver, that should be free from that
> issue.
>
> While being at it, get rid of depreciated omap_read/write(), use ioremap()
> instead.
>
> Created and tested against linux-2.6.37-rc5 on Amstrad Delta.
>
> Signed-off-by: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Sorry, but would it please be possible to split this few small patches -
this one is too difficult to review, at least for me.
Thanks!
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Cc: linux-mtd@lists.infradead.org, Tony Lindgren <tony@atomide.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
David Woodhouse <dwmw2@infradead.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] MTD: NAND: ams-delta: convert to platform driver
Date: Tue, 14 Dec 2010 19:00:23 +0200 [thread overview]
Message-ID: <1292346023.2538.103.camel@localhost> (raw)
In-Reply-To: <201012111840.05270.jkrzyszt@tis.icnet.pl>
On Sat, 2010-12-11 at 18:40 +0100, Janusz Krzysztofik wrote:
> In its current form, the driver may break unrelated machines if built into the
> kernel, hence is not suitable for inclusion into a kernel built for multiple
> OMAP1 machines. Convert it to a platform driver, that should be free from that
> issue.
>
> While being at it, get rid of depreciated omap_read/write(), use ioremap()
> instead.
>
> Created and tested against linux-2.6.37-rc5 on Amstrad Delta.
>
> Signed-off-by: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Sorry, but would it please be possible to split this few small patches -
this one is too difficult to review, at least for me.
Thanks!
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: dedekind1@gmail.com (Artem Bityutskiy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] MTD: NAND: ams-delta: convert to platform driver
Date: Tue, 14 Dec 2010 19:00:23 +0200 [thread overview]
Message-ID: <1292346023.2538.103.camel@localhost> (raw)
In-Reply-To: <201012111840.05270.jkrzyszt@tis.icnet.pl>
On Sat, 2010-12-11 at 18:40 +0100, Janusz Krzysztofik wrote:
> In its current form, the driver may break unrelated machines if built into the
> kernel, hence is not suitable for inclusion into a kernel built for multiple
> OMAP1 machines. Convert it to a platform driver, that should be free from that
> issue.
>
> While being at it, get rid of depreciated omap_read/write(), use ioremap()
> instead.
>
> Created and tested against linux-2.6.37-rc5 on Amstrad Delta.
>
> Signed-off-by: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Sorry, but would it please be possible to split this few small patches -
this one is too difficult to review, at least for me.
Thanks!
--
Best Regards,
Artem Bityutskiy (????? ????????)
next prev parent reply other threads:[~2010-12-14 17:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-11 17:40 [PATCH] MTD: NAND: ams-delta: convert to platform driver Janusz Krzysztofik
2010-12-11 17:40 ` Janusz Krzysztofik
2010-12-14 17:00 ` Artem Bityutskiy [this message]
2010-12-14 17:00 ` Artem Bityutskiy
2010-12-14 17:00 ` Artem Bityutskiy
2010-12-14 20:09 ` [PATCH v2] " Janusz Krzysztofik
2010-12-14 20:09 ` Janusz Krzysztofik
2010-12-14 20:09 ` Janusz Krzysztofik
2010-12-14 22:28 ` Tony Lindgren
2010-12-14 22:28 ` Tony Lindgren
2010-12-14 22:28 ` Tony Lindgren
2010-12-15 9:37 ` Artem Bityutskiy
2010-12-15 9:37 ` Artem Bityutskiy
2010-12-15 9:37 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292346023.2538.103.camel@localhost \
--to=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=jkrzyszt@tis.icnet.pl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.