Errors on compiling master-backport of ceph-client-standalone

Errors on compiling master-backport of ceph-client-standalone

[Henry C Chang]

Hi,

Just tried to compile master-backport of ceph-client-standalone and got errors.
I did two modifications to fix the errors:

1. include <linux/smp_lock.h> in ceph/mds_client.c for lock_kernel()
2. Revert commit "convert ceph"
(ff8a8d2006dca58f71b5dc5df0c95b8f837a0a4e) because mount operation
does not exist before 2.6.37.

Henry

Re: Errors on compiling master-backport of ceph-client-standalone

[Jeff Wu]

在 2010-12-16四的 15:39 +0800，Henry C Chang写道：
> Hi,
> 
> Just tried to compile master-backport of ceph-client-standalone and got errors.
> I did two modifications to fix the errors:
> 
> 1. include <linux/smp_lock.h> in ceph/mds_client.c for lock_kernel()
> 2. Revert commit "convert ceph"
> (ff8a8d2006dca58f71b5dc5df0c95b8f837a0a4e) because mount operation
> does not exist before 2.6.37.
I also compiled fail for ceph-client-standalone : master &&
master-backport.
 LINUX_VERSION_CODE > KERNEL_VERSION(2, 6, 36),
struct file_system_type added  "mount".

---------
static struct file_system_type ceph_fs_type = {
        .owner          = THIS_MODULE,
         .name           = "ceph",
         .mount          = ceph_mount,
         .kill_sb        = ceph_kill_sb,
         .fs_flags       = FS_RENAME_DOES_D_MOVE,
};
 



> 
> Henry
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Errors on compiling master-backport of ceph-client-standalone

[Sage Weil]

On Thu, 16 Dec 2010, Henry C Chang wrote:
> Hi,
> 
> Just tried to compile master-backport of ceph-client-standalone and got errors.
> I did two modifications to fix the errors:
> 
> 1. include <linux/smp_lock.h> in ceph/mds_client.c for lock_kernel()

Pushed this to the master-backport branch.

> 2. Revert commit "convert ceph"
> (ff8a8d2006dca58f71b5dc5df0c95b8f837a0a4e) because mount operation
> does not exist before 2.6.37.

Sigh... this one is going to be a pain to surround with kernel version 
#ifdefs.  The commit that needs to be conditional on the version is Al's, 
ff8a8d20.  Any takers?

sage

Re: Errors on compiling master-backport of ceph-client-standalone

[Henry Chang]

> Sigh... this one is going to be a pain to surround with kernel version
> #ifdefs.  The commit that needs to be conditional on the version is Al's,
> ff8a8d20.  Any takers?

Fixed by two patches:
1. include version.h for kernel version checking
https://github.com/tcloud/ceph-client-standalone/commit/c1696dc02658ae98f2d8c94f03624b18acc8a20a

2. backport mount pre 2.6.37
https://github.com/tcloud/ceph-client-standalone/commit/704ba2ce3aac60fbdc7d10e229f8d93ffe87389f

Re: Errors on compiling master-backport of ceph-client-standalone

[Sage Weil]

On Wed, 29 Dec 2010, Henry Chang wrote:
> > Sigh... this one is going to be a pain to surround with kernel version
> > #ifdefs.  The commit that needs to be conditional on the version is Al's,
> > ff8a8d20.  Any takers?
> 
> Fixed by two patches:
> 1. include version.h for kernel version checking
> https://github.com/tcloud/ceph-client-standalone/commit/c1696dc02658ae98f2d8c94f03624b18acc8a20a
> 
> 2. backport mount pre 2.6.37
> https://github.com/tcloud/ceph-client-standalone/commit/704ba2ce3aac60fbdc7d10e229f8d93ffe87389f

Thanks!  These are applied.

There are two new patches in unstable now that need backports, too :(... 
the create_workqueue cleanups from Tejun.  The backport essentially needs 
to revert the patch (keep the QUEUED/BUSY bits in place) for older 
kernels.

sage