All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] ASoC: sh: fsi: move fsi_irq_enable function to fsi_dai_trigger
@ 2010-12-17  3:52 Kuninori Morimoto
  2010-12-17 10:48 ` Liam Girdwood
  2010-12-17 12:58 ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Kuninori Morimoto @ 2010-12-17  3:52 UTC (permalink / raw)
  To: Mark Brown; +Cc: Linux-ALSA, Liam Girdwood

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 sound/soc/sh/fsi.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/sound/soc/sh/fsi.c b/sound/soc/sh/fsi.c
index 97c5394..9ab8593 100644
--- a/sound/soc/sh/fsi.c
+++ b/sound/soc/sh/fsi.c
@@ -684,9 +684,6 @@ static int fsi_fifo_data_ctrl(struct fsi_priv *fsi, int startup, int stream)
 		fsi_reg_write(fsi, DOFF_ST, 0) :
 		fsi_reg_write(fsi, DIFF_ST, 0);
 
-	/* re-enable irq */
-	fsi_irq_enable(fsi, is_play);
-
 	if (over_period)
 		snd_pcm_period_elapsed(substream);
 
@@ -859,6 +856,7 @@ static int fsi_dai_trigger(struct snd_pcm_substream *substream, int cmd,
 				frames_to_bytes(runtime, runtime->buffer_size),
 				frames_to_bytes(runtime, runtime->period_size));
 		ret = is_play ? fsi_data_push(fsi, 1) : fsi_data_pop(fsi, 1);
+		fsi_irq_enable(fsi, is_play);
 		break;
 	case SNDRV_PCM_TRIGGER_STOP:
 		fsi_irq_disable(fsi, is_play);
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] ASoC: sh: fsi: move fsi_irq_enable function to fsi_dai_trigger
  2010-12-17  3:52 [PATCH 1/2] ASoC: sh: fsi: move fsi_irq_enable function to fsi_dai_trigger Kuninori Morimoto
@ 2010-12-17 10:48 ` Liam Girdwood
  2010-12-17 12:58 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2010-12-17 10:48 UTC (permalink / raw)
  To: Kuninori Morimoto; +Cc: Linux-ALSA, Mark Brown

On Fri, 2010-12-17 at 12:52 +0900, Kuninori Morimoto wrote:
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
>  sound/soc/sh/fsi.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)

Both

Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] ASoC: sh: fsi: move fsi_irq_enable function to fsi_dai_trigger
  2010-12-17  3:52 [PATCH 1/2] ASoC: sh: fsi: move fsi_irq_enable function to fsi_dai_trigger Kuninori Morimoto
  2010-12-17 10:48 ` Liam Girdwood
@ 2010-12-17 12:58 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2010-12-17 12:58 UTC (permalink / raw)
  To: Kuninori Morimoto; +Cc: Linux-ALSA, Liam Girdwood

On Fri, Dec 17, 2010 at 12:52:56PM +0900, Kuninori Morimoto wrote:
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-12-17 12:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-17  3:52 [PATCH 1/2] ASoC: sh: fsi: move fsi_irq_enable function to fsi_dai_trigger Kuninori Morimoto
2010-12-17 10:48 ` Liam Girdwood
2010-12-17 12:58 ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.