All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Clifton <pcjc2@cam.ac.uk>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Intel <intel-gfx@lists.freedesktop.org>
Subject: Re: BISECTED: Suspend regression on drm-intel-next
Date: Sun, 19 Dec 2010 10:05:25 +0000	[thread overview]
Message-ID: <1292753125.2386.2.camel@pcjc2lap> (raw)
In-Reply-To: <849307$aqoaem@azsmga001.ch.intel.com>

On Sat, 2010-12-18 at 21:42 +0000, Chris Wilson wrote:
> On Sat, 18 Dec 2010 20:02:21 +0000, Peter Clifton <pcjc2@cam.ac.uk> wrote:
> > Hi Chris,
> > 
> > I bisected the suspend regression I mentioned, and came to this commit:
> > 
> > commit 0cdab21f9a1fca50dd27e488839f5a6578e333b2
> > Author: Chris Wilson <chris@chris-wilson.co.uk>
> > Date:   Sun Dec 5 17:27:06 2010 +0000
> > 
> >     drm/i915: Uncouple render/power ctx before suspending
> >     
> >     Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > 
> > 
> > Disabling power context tear down on suspend with this diff:
> 
> And you verified the revert against drm-intel-next HEAD? I'll revert just
> as soon as I see your confirmation. :)

Confirmed.. drm-intel-next is still broken.

I'm vaguely curious why it makes it lock up, but I'll settle for it not
doing so ;)  Only since suspend has been broken did I realise just how
much I rely upon it!

> [The patch was only trying to see if it made Ironlake stable on suspending
> with renderctx, to no avail so there should be no repercussions in
> reverting.]

Good to hear.

Best wishes,

-- 
Peter Clifton

Electrical Engineering Division,
Engineering Department,
University of Cambridge,
9, JJ Thomson Avenue,
Cambridge
CB3 0FA

Tel: +44 (0)7729 980173 - (No signal in the lab!)
Tel: +44 (0)1223 748328 - (Shared lab phone, ask for me)

      reply	other threads:[~2010-12-19 10:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-18 20:02 BISECTED: Suspend regression on drm-intel-next Peter Clifton
2010-12-18 21:42 ` Chris Wilson
2010-12-19 10:05   ` Peter Clifton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1292753125.2386.2.camel@pcjc2lap \
    --to=pcjc2@cam.ac.uk \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.