mpd: COMMERCIAL_LICENSE etc

mpd: COMMERCIAL_LICENSE etc

[Frans Meulenbroeks]

Hi,

I was trying to add mpd to poky and bumped upon COMMERCIAL_LICENSE
Should I set
COMMERCIAL_LICENSE = ""
in my local.conf. That allows me to add lame etc to mpd.
Not sure if that is the desired way. Overruling COMMERCIAL_LICENSE seems wrong.

I'm also stuct at how to add these conditionally.
The OE recipe has:
           ${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'libmad
libid3tag lame', d)}"
I tried replacing ENTERPRISE_DISTRO with COMMERCIAL_LICENSE but that
did not work as it is not a boolean var
and my python is not good enough to come up with a better fix.

Frans.

PS: any suggestion on how/where to submit this recipe and the ones I
added for it (audiofile, faad2, liba0, libmkidmod)

Re: mpd: COMMERCIAL_LICENSE etc

[Joshua Lock]

On Sat, 2010-12-18 at 18:26 +0100, Frans Meulenbroeks wrote:
> Hi,
> 
> I was trying to add mpd to poky and bumped upon COMMERCIAL_LICENSE
> Should I set
> COMMERCIAL_LICENSE = ""
> in my local.conf. That allows me to add lame etc to mpd.
> Not sure if that is the desired way. Overruling COMMERCIAL_LICENSE seems wrong.

This is something we need to document better, and I filed a bug about
that recently (#576).

There's a comment in poky.conf on how the variable is used
(http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/conf/distro/poky.conf#n130) as well as a comment on the bug I filed (http://bugzilla.pokylinux.org/show_bug.cgi?id=576#c1)

> 
> I'm also stuct at how to add these conditionally.
> The OE recipe has:
>            ${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'libmad
> libid3tag lame', d)}"
> I tried replacing ENTERPRISE_DISTRO with COMMERCIAL_LICENSE but that
> did not work as it is not a boolean var
> and my python is not good enough to come up with a better fix.

I think adding a boolean value for detecting whether we can build this
software would be a great idea, care to file a bug?

Cheers,
Joshua
-- 
Joshua Lock
        Intel Open Source Technology Centre