Re: [PATCH v2 7/9] ofono-rules: Add cdmagen device

[Marcel Holtmann <marcel@holtmann.org>]

[-- Attachment #1: Type: text/plain, Size: 1761 bytes --]

Hi Dara,

> >>   plugins/ofono.rules |    4 ++++
> >>   1 files changed, 4 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/plugins/ofono.rules b/plugins/ofono.rules
> >> index da8a8ef..34698f0 100644
> >> --- a/plugins/ofono.rules
> >> +++ b/plugins/ofono.rules
> >> @@ -429,6 +429,10 @@ ATTRS{idVendor}=="0930", ATTRS{idProduct}=="1311", ENV{OFONO_DRIVER}="mbm"
> >>   # Nokia Internet Stick CS-10
> >>   ATTRS{idVendor}=="0421", ATTRS{idProduct}=="060e", ENV{OFONO_DRIVER}="nokia"
> >>
> >> +# Nokia CDMA Device
> >> +ATTRS{idVendor}=="0421", ATTRS{idProduct}=="023e", ENV{OFONO_DRIVER}="cdmagen"
> >> +ATTRS{idVendor}=="0421", ATTRS{idProduct}=="00b6", ENV{OFONO_DRIVER}="cdmagen"
> >> +
> >
> > since this is Nokia specific device, then using nokiacdma would be a
> > better name. Or using OFONO_DRIVER=nokia NOKIA_MODE=cdma and sharing the
> > driver might be useful.
> >
> > It really all depends how much they have in common.
> 
> Nothing. All Nokia CDMA devices actually contain Qualcomm modems, so 
> perhaps a better name may be along the lines of "msmcdmamodem" for CDMA 
> AT modem devices in a tethered mode?
> 
> So what kind of
> > hardware is this actually? A phone or a real USB dongle?
> >
> It is a phone.

so calling this driver "nokiacdma" sounds a bit better to me. It makes
it clear that the device is from Nokia. If you wanna shotcut it into
"nokcdma" then that is also fine with me, but it should reflect what it
is.

Even the Nokia datacard contains a Qualcomm modem btw. It is just GSM
instead of CDMA. So it is not that far away from the phone in tethered
mode than you think. If you wanna go with the NOKIA_MODE=gsm|cdma, then
I would be fine with it as well.

Regards

Marcel