From: Kevin Hilman <khilman@ti.com>
To: Mika Westerberg <ext-mika.1.westerberg@nokia.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
tony@atomide.com
Subject: Re: [PATCH] OMAP: GPIO: fix _set_gpio_triggering() for OMAP2+
Date: Tue, 04 Jan 2011 14:45:54 -0800 [thread overview]
Message-ID: <1294181154.18162.39.camel@localhost> (raw)
In-Reply-To: <87aajg7dzu.fsf@ti.com>
On Tue, 2011-01-04 at 09:52 -0800, Kevin Hilman wrote:
> Mika Westerberg <ext-mika.1.westerberg@nokia.com> writes:
>
> > In case on OMAP2+ we call set_24xx_gpio_triggering() instead of
> > updating reg and l values. However, at the end of the function we
> > perform a write:
> >
> > __raw_writel(l, reg);
> >
> > So on OMAP2+ we end up writing 0 to the bank->base which is not
> > correct (typically this points to GPIO_REVISION register).
> >
> > Fix this by returning immediately after call to
> > set_24xx_gpio_triggering().
> >
> > Signed-off-by: Mika Westerberg <ext-mika.1.westerberg@nokia.com>
>
> Acked-by: Kevin Hilman <khilman@ti.com>
>
> Tony, this should be added to omap-for-linus as it fixes a problem in
> the recently merged GPIO omap_device/hwmod conversion.
On second thought, it's a bit late for the main 2.6.38 window, so will
queue this in my pm-fixes branch for the .38-rc cycle.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] OMAP: GPIO: fix _set_gpio_triggering() for OMAP2+
Date: Tue, 04 Jan 2011 14:45:54 -0800 [thread overview]
Message-ID: <1294181154.18162.39.camel@localhost> (raw)
In-Reply-To: <87aajg7dzu.fsf@ti.com>
On Tue, 2011-01-04 at 09:52 -0800, Kevin Hilman wrote:
> Mika Westerberg <ext-mika.1.westerberg@nokia.com> writes:
>
> > In case on OMAP2+ we call set_24xx_gpio_triggering() instead of
> > updating reg and l values. However, at the end of the function we
> > perform a write:
> >
> > __raw_writel(l, reg);
> >
> > So on OMAP2+ we end up writing 0 to the bank->base which is not
> > correct (typically this points to GPIO_REVISION register).
> >
> > Fix this by returning immediately after call to
> > set_24xx_gpio_triggering().
> >
> > Signed-off-by: Mika Westerberg <ext-mika.1.westerberg@nokia.com>
>
> Acked-by: Kevin Hilman <khilman@ti.com>
>
> Tony, this should be added to omap-for-linus as it fixes a problem in
> the recently merged GPIO omap_device/hwmod conversion.
On second thought, it's a bit late for the main 2.6.38 window, so will
queue this in my pm-fixes branch for the .38-rc cycle.
Kevin
next prev parent reply other threads:[~2011-01-04 22:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-29 11:01 [PATCH] OMAP: GPIO: fix _set_gpio_triggering() for OMAP2+ Mika Westerberg
2010-12-29 11:01 ` Mika Westerberg
2011-01-04 17:52 ` Kevin Hilman
2011-01-04 17:52 ` Kevin Hilman
2011-01-04 22:45 ` Kevin Hilman [this message]
2011-01-04 22:45 ` Kevin Hilman
2011-01-04 23:17 ` Tony Lindgren
2011-01-04 23:17 ` Tony Lindgren
2011-01-05 10:22 ` Varadarajan, Charulatha
2011-01-05 10:22 ` Varadarajan, Charulatha
2011-01-05 16:54 ` Kevin Hilman
2011-01-05 16:54 ` Kevin Hilman
2011-01-06 18:12 ` Mika Westerberg
2011-01-06 18:12 ` Mika Westerberg
2011-01-06 18:34 ` Kevin Hilman
2011-01-06 18:34 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294181154.18162.39.camel@localhost \
--to=khilman@ti.com \
--cc=ext-mika.1.westerberg@nokia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.