All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Liang Z Li <liang.z.li@intel.com>
Cc: amit shah <amit.shah@redhat.com>,
	mst@redhat.com, qemu-devel@nongnu.org, quintela@redhat.com
Subject: Re: [Qemu-devel] [v2 1/2] cutils: add avx2 instruction optimization
Date: Fri, 13 Nov 2015 04:30:53 -0500 (EST)	[thread overview]
Message-ID: <1294522305.12149399.1447407053948.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <F2CBF3009FA73547804AE4C663CAB28E019A5479@shsmsx102.ccr.corp.intel.com>


> > ... define buffer_find_nonzero_offset_inner ...
> > ... define can_use_buffer_find_nonzero_offset_inner ...
> 
> > #if defined CONFIG_HAVE_GNU_IFUNC && defined CONFIG_HAVE_AVX2 ...
> > define buffer_find_nonzero_offset_avx2 ...
> > ... define can_use_buffer_find_nonzero_offset_avx2 ...
> > ... define the indirect functions ...
> > #else
> > ... define buffer_find_nonzero_offset that just calls
> > buffer_find_nonzero_offset_inner ...
> > ... define can_use_buffer_find_nonzero_offset that just calls
> > can_use_buffer_find_nonzero_offset_inner ...
> > #endif
> > 
> > Thanks,
> > 
> > Paolo
> 
> The buffer_find_nonzero_offset_inner  & buffer_find_nonzero_offset_avx2
> can't defined in the same .c file.
> Or, if the '-maxv2' is enabled, the " buffer_find_nonzero_offset_inner  ()"
> will be compiled to AVX2 instructions.

You can use __attribute__((__target__("avx2"))) on the avx2 version,
instead of compiling the whole file with -mavx2.

Paolo

  reply	other threads:[~2015-11-13  9:31 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-10  2:51 [Qemu-devel] [v2 0/2] add avx2 instruction optimization Liang Li
2015-11-10  2:51 ` [Qemu-devel] [v2 1/2] cutils: " Liang Li
2015-11-12 10:08   ` Paolo Bonzini
2015-11-12 10:12     ` Li, Liang Z
2015-11-12 11:30     ` Juan Quintela
2015-11-13  2:49     ` Li, Liang Z
2015-11-13  9:30       ` Paolo Bonzini [this message]
2015-11-12 14:43   ` Richard Henderson
2015-11-10  2:51 ` [Qemu-devel] [v2 2/2] configure: add options to config avx2 Liang Li
2015-11-10  3:43 ` [Qemu-devel] [v2 0/2] add avx2 instruction optimization Eric Blake
2015-11-10  5:48   ` Li, Liang Z
2015-11-10  9:13     ` Juan Quintela
2015-11-10  9:26       ` Li, Liang Z
2015-11-10  9:35         ` Paolo Bonzini
2015-11-10  9:41           ` Li, Liang Z
2015-11-10  9:50             ` Paolo Bonzini
2015-11-10  9:56               ` Li, Liang Z
2015-11-10 10:00                 ` Paolo Bonzini
2015-11-10 10:04                   ` Li, Liang Z
2015-11-12  2:49           ` Li, Liang Z
2015-11-12  8:43             ` Paolo Bonzini
2015-11-12  8:53               ` Li, Liang Z
2015-11-12  9:04                 ` Paolo Bonzini
2015-11-12  9:40                   ` Li, Liang Z
2015-11-12  9:45                     ` Paolo Bonzini
2015-11-12  9:53                       ` Li, Liang Z
2015-11-12 11:34                         ` Juan Quintela
2015-11-12 11:42                           ` Li, Liang Z
2015-11-12 19:56                             ` Dr. David Alan Gilbert
2015-11-12 20:20                               ` Eric Blake
2016-04-07 11:09                                 ` Dr. David Alan Gilbert
2016-04-07 12:54                                   ` Michael S. Tsirkin
2016-04-07 13:42                                     ` Dr. David Alan Gilbert
2016-04-07 13:54                                     ` Paolo Bonzini
2015-11-10  9:30       ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1294522305.12149399.1447407053948.JavaMail.zimbra@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=liang.z.li@intel.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.