All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Neuling <mikey@neuling.org>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: linuxppc-dev@ozlabs.org, horms@verge.net.au,
	kexec@lists.infradead.org, miltonm@bga.com
Subject: Re: [PATCH] kexec ppc64: fix misaligned cmdline
Date: Tue, 05 Jun 2007 10:58:07 +1000	[thread overview]
Message-ID: <12946.1181005087@neuling.org> (raw)
In-Reply-To: <20070605001632.GA26483@localhost.localdomain>

> On Tue, Jun 05, 2007 at 09:56:37AM +1000, Miichael Neuling wrote:
> > > > If the cmdline changes between boots, we can get misalignment of the
> > > > bootargs entry, which in turn corrupts our device tree blob and hence
> > > > kills our kexec boot.  
> > > > 
> > > > Specifically, if the cmdline length was >= 8 before and the new cmdline
> > > > length is < 8, we can get corruption.
> > > 
> > > Hrm.  Have you considered using dtc for this conversion, rather than
> > > this somewhat dubious looking fs2dt?
> > 
> > Numerous times.  
> > 
> > fs2dt needs to be converted to use the device tree library, but that
> > will take a lot more work than a 5 minute patch.
> 
> 
> Well, sure.. but do you need fs2dt at all.  dtc has an "fs" input
> mode..

As discussed offline, you can do this with the --devicetreeblob kexec
option.  The issue is the special cases like having to modify the kernel
cmdline options or initrd locations.

Mikey

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Michael Neuling <mikey@neuling.org>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: linuxppc-dev@ozlabs.org, horms@verge.net.au,
	kexec@lists.infradead.org, miltonm@bga.com
Subject: Re: [PATCH] kexec ppc64: fix misaligned cmdline
Date: Tue, 05 Jun 2007 10:58:07 +1000	[thread overview]
Message-ID: <12946.1181005087@neuling.org> (raw)
In-Reply-To: <20070605001632.GA26483@localhost.localdomain>

> On Tue, Jun 05, 2007 at 09:56:37AM +1000, Miichael Neuling wrote:
> > > > If the cmdline changes between boots, we can get misalignment of the
> > > > bootargs entry, which in turn corrupts our device tree blob and hence
> > > > kills our kexec boot.  
> > > > 
> > > > Specifically, if the cmdline length was >= 8 before and the new cmdline
> > > > length is < 8, we can get corruption.
> > > 
> > > Hrm.  Have you considered using dtc for this conversion, rather than
> > > this somewhat dubious looking fs2dt?
> > 
> > Numerous times.  
> > 
> > fs2dt needs to be converted to use the device tree library, but that
> > will take a lot more work than a 5 minute patch.
> 
> 
> Well, sure.. but do you need fs2dt at all.  dtc has an "fs" input
> mode..

As discussed offline, you can do this with the --devicetreeblob kexec
option.  The issue is the special cases like having to modify the kernel
cmdline options or initrd locations.

Mikey

  reply	other threads:[~2007-06-05  0:59 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-04  7:23 [PATCH] kexec ppc64: fix misaligned cmdline Michael Neuling
2007-06-04  7:23 ` Michael Neuling
2007-06-04  9:22 ` Milton Miller
2007-06-04  9:22   ` Milton Miller
2007-06-04  9:42   ` Michael Neuling
2007-06-04  9:42     ` Michael Neuling
2007-06-05  8:22     ` root= cmdline modification in kexec (was Re: [PATCH] kexec ppc64: fix misaligned cmdline ) Michael Neuling
2007-06-06  5:31       ` Mohan Kumar M
2007-06-07  1:19     ` [PATCH] kexec ppc64: fix misaligned cmdline Michael Neuling
2007-06-07  1:19       ` Michael Neuling
2007-06-07 16:19       ` Geoff Levand
2007-06-07 16:19         ` Geoff Levand
2007-06-19  5:06       ` Horms
2007-06-19  5:06         ` Horms
2007-06-04 23:49 ` David Gibson
2007-06-04 23:49   ` David Gibson
2007-06-04 23:56   ` Michael Neuling
2007-06-04 23:56     ` Michael Neuling
2007-06-05  0:16     ` David Gibson
2007-06-05  0:16       ` David Gibson
2007-06-05  0:58       ` Michael Neuling [this message]
2007-06-05  0:58         ` Michael Neuling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12946.1181005087@neuling.org \
    --to=mikey@neuling.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=horms@verge.net.au \
    --cc=kexec@lists.infradead.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=miltonm@bga.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.