From: Daniel Walker <dwalker@codeaurora.org>
To: Dima Zavin <dmitriyz@google.com>
Cc: Gregory Bean <gbean@codeaurora.org>,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5 v4] msm: convert 7x30 to gpiomux.
Date: Mon, 10 Jan 2011 09:33:30 -0800 [thread overview]
Message-ID: <1294680810.12298.2.camel@c-dwalke-linux.qualcomm.com> (raw)
In-Reply-To: <AANLkTikrLnGxNSJgv3KDNAQ5kvjNd8aPrOEBwftiiyrQ@mail.gmail.com>
On Sun, 2011-01-09 at 14:53 -0800, Dima Zavin wrote:
> Greg,
>
> Just rebased on top of 2.6.37 and this patch is totally the wrong way
> to go about this.
>
> I should have commented at the appropriate time, so sorry for the late reply.
>
> Having this msm_gpiomux_configs be always compiled in for all msm7x30
> devices makes this entire system completely inflexible since you have
> to modify common code to provide board specific initialization. The
> definition of "msm_gpiomux_configs" belongs in the board file, not in
> gpiomux-7x30.c. I think we need to delete this new file and move the
> definition back into board-msm7x30.c, but just use the new gpiomux
> APIs.
>
> I can provide a patch if you like.
I would just provide the patch .. It would be easier to understand what
your talking about.
Daniel
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
WARNING: multiple messages have this Message-ID (diff)
From: dwalker@codeaurora.org (Daniel Walker)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5 v4] msm: convert 7x30 to gpiomux.
Date: Mon, 10 Jan 2011 09:33:30 -0800 [thread overview]
Message-ID: <1294680810.12298.2.camel@c-dwalke-linux.qualcomm.com> (raw)
In-Reply-To: <AANLkTikrLnGxNSJgv3KDNAQ5kvjNd8aPrOEBwftiiyrQ@mail.gmail.com>
On Sun, 2011-01-09 at 14:53 -0800, Dima Zavin wrote:
> Greg,
>
> Just rebased on top of 2.6.37 and this patch is totally the wrong way
> to go about this.
>
> I should have commented at the appropriate time, so sorry for the late reply.
>
> Having this msm_gpiomux_configs be always compiled in for all msm7x30
> devices makes this entire system completely inflexible since you have
> to modify common code to provide board specific initialization. The
> definition of "msm_gpiomux_configs" belongs in the board file, not in
> gpiomux-7x30.c. I think we need to delete this new file and move the
> definition back into board-msm7x30.c, but just use the new gpiomux
> APIs.
>
> I can provide a patch if you like.
I would just provide the patch .. It would be easier to understand what
your talking about.
Daniel
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2011-01-10 17:33 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-28 17:05 [PATCH 1/5 v4] msm: add gpiomux api for gpio multiplex & configuration Gregory Bean
2010-08-28 17:05 ` Gregory Bean
2010-08-28 17:05 ` [PATCH 2/5 v4] msm: documentation: add gpiomux documentation Gregory Bean
2010-08-28 17:05 ` Gregory Bean
2010-08-28 17:05 ` [PATCH 3/5 v4] msm: convert 8x50 to gpiomux Gregory Bean
2010-08-28 17:05 ` Gregory Bean
2010-08-28 17:05 ` [PATCH 4/5 v4] msm: convert 7x30 " Gregory Bean
2010-08-28 17:05 ` Gregory Bean
2011-01-09 22:53 ` Dima Zavin
2011-01-09 22:53 ` Dima Zavin
2011-01-09 22:53 ` Dima Zavin
2011-01-10 17:33 ` Daniel Walker [this message]
2011-01-10 17:33 ` Daniel Walker
2011-01-10 19:00 ` [PATCH] ARM: msm: 7x30: don't force a gpiomux table for the whole arch Dima Zavin
2011-01-10 19:00 ` Dima Zavin
2011-01-14 3:35 ` Rohit Vaswani
2011-01-14 3:35 ` Rohit Vaswani
2011-01-14 21:08 ` Daniel Walker
2011-01-14 21:08 ` Daniel Walker
2011-01-14 18:16 ` David Brown
2011-01-14 18:16 ` David Brown
2011-01-14 19:17 ` Dima Zavin
2011-01-14 19:17 ` Dima Zavin
2011-01-10 22:43 ` [PATCH 4/5 v4] msm: convert 7x30 to gpiomux Dima Zavin
2011-01-10 22:43 ` Dima Zavin
2011-01-10 22:43 ` Dima Zavin
2010-08-28 17:05 ` [PATCH 5/5 v4] msm: gpio: Remove tlmm routines obsoleted by gpiomux Gregory Bean
2010-08-28 17:05 ` Gregory Bean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294680810.12298.2.camel@c-dwalke-linux.qualcomm.com \
--to=dwalker@codeaurora.org \
--cc=dmitriyz@google.com \
--cc=gbean@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.