From: Johannes Berg <johannes@sipsolutions.net>
To: Eliad Peller <eliad@wizery.com>
Cc: Luciano Coelho <coelho@ti.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wl12xx: fix some sparse warnings
Date: Sun, 16 Jan 2011 09:28:42 +0100 [thread overview]
Message-ID: <1295166522.3574.1.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1295164184-25592-1-git-send-email-eliad@wizery.com>
On Sun, 2011-01-16 at 09:49 +0200, Eliad Peller wrote:
> @@ -813,7 +813,7 @@ int wl1271_acx_ap_rate_policy(struct wl1271 *wl, struct conf_tx_rate_class *c,
> acx->rate_policy.long_retry_limit = c->long_retry_limit;
> acx->rate_policy.aflags = c->aflags;
>
> - acx->rate_policy_idx = idx;
> + acx->rate_policy_idx = __cpu_to_le32(idx);
The underscore version doesn't look appropriate at this point or in fact
anywhere in this patch.
Also, your patch subject and commit log is wrong -- this doesn't just
fix sparse warnings, it fixes actual bugs pointed out by sparse, so
commit log should reflect that.
johannes
next prev parent reply other threads:[~2011-01-16 8:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-16 7:49 [PATCH] wl12xx: fix some sparse warnings Eliad Peller
2011-01-16 8:28 ` Johannes Berg [this message]
2011-01-16 8:48 ` Eliad Peller
2011-01-16 8:52 ` Johannes Berg
-- strict thread matches above, loose matches on Subject: below --
2010-12-22 11:38 Eliad Peller
2011-01-10 16:02 ` Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295166522.3574.1.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=coelho@ti.com \
--cc=eliad@wizery.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.