Re: [PATCH] wl12xx: fix some sparse warnings

[Johannes Berg <johannes@sipsolutions.net>]

On Sun, 2011-01-16 at 10:48 +0200, Eliad Peller wrote:

> >> -     acx->rate_policy_idx = idx;
> >> +     acx->rate_policy_idx = __cpu_to_le32(idx);
> >
> > The underscore version doesn't look appropriate at this point or in fact
> > anywhere in this patch.
> >
> > Also, your patch subject and commit log is wrong -- this doesn't just
> > fix sparse warnings, it fixes actual bugs pointed out by sparse, so
> > commit log should reflect that.
> >
> thanks for your review!
> i'll send a new version.
> 
> what is the difference between the normal and underscore version?
> atomicity? (i didn't find a documentation about it)

Generally underscore versions are more "internal" APIs. In this case, I
believe the underscore version is usable in places where the compiler
needs a constant as the output, I'm not quite sure though.

johannes