Re: [PATCH] ste: Use UTF-8 as a default character set

[Marcel Holtmann <marcel@holtmann.org>]

[-- Attachment #1: Type: text/plain, Size: 824 bytes --]

Hi Lasse,

>  plugins/ste.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/plugins/ste.c b/plugins/ste.c
> index 7bb7232..cc01f7b 100644
> --- a/plugins/ste.c
> +++ b/plugins/ste.c
> @@ -247,7 +247,7 @@ static int ste_enable(struct ofono_modem *modem)
>  		return -EIO;
>  
>  	data->chat = g_at_chat_new_blocking(channel, syntax);
> -	g_at_chat_send(data->chat, "AT&F E0 V1 X4 &C1 +CMEE=1",
> +	g_at_chat_send(data->chat, "AT&F E0 V1 X4 &C1 +CMEE=1;+CSCS=\"UTF-8\"",
>  			NULL, NULL, NULL, NULL);

is it guaranteed that every single STE modem supports UTF-8 character
set?

I would rather see a new command checking for supported character sets
and then picking the default. And intermixing with ATE is not really
clean from my perspective.

Regards

Marcel