Re: [PATCH] ste: Use UTF-8 as a default character set

[Marcel Holtmann <marcel@holtmann.org>]

[-- Attachment #1: Type: text/plain, Size: 1062 bytes --]

Hi Laase,

> > is it guaranteed that every single STE modem supports UTF-8 character
> > set?
> > 
> Based on information I have, yes, every single ste modem support UTF-8.
> 
> > I would rather see a new command checking for supported character sets
> > and then picking the default. And intermixing with ATE is not really
> > clean from my perspective.
> You want this to be changed accordingly? I tried to to follow minimalism
> in this simple change and not to introduce new functions. If command
> fails for some reason, modem uses its default value, which is IRA. It
> could be on a separate line, but still I would not add a call back for
> it, nothing to do if the command fails. I prefer the patch I sent, but
> you can decide 

so at least use AT+CSCS=\"UTF-8\" as a separate command after the init
command and put a comment above that all STE modems support UTF-8.

And to answer your question, I have seen other modems misbehaving when
it comes to charsets and even lying to use. That is why I asked ;)

Regards

Marcel