[PATCH] ste: Use UTF-8 as a default character set

[PATCH] ste: Use UTF-8 as a default character set

[Lasse Kunnasluoto]

[-- Attachment #1: Type: text/plain, Size: 563 bytes --]

---
 plugins/ste.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/plugins/ste.c b/plugins/ste.c
index 7bb7232..cc01f7b 100644
--- a/plugins/ste.c
+++ b/plugins/ste.c
@@ -247,7 +247,7 @@ static int ste_enable(struct ofono_modem *modem)
 		return -EIO;
 
 	data->chat = g_at_chat_new_blocking(channel, syntax);
-	g_at_chat_send(data->chat, "AT&F E0 V1 X4 &C1 +CMEE=1",
+	g_at_chat_send(data->chat, "AT&F E0 V1 X4 &C1 +CMEE=1;+CSCS=\"UTF-8\"",
 			NULL, NULL, NULL, NULL);
 
 	g_io_channel_unref(channel);
-- 
1.7.0.4

Re: [PATCH] ste: Use UTF-8 as a default character set

[Marcel Holtmann]

[-- Attachment #1: Type: text/plain, Size: 824 bytes --]

Hi Lasse,

>  plugins/ste.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/plugins/ste.c b/plugins/ste.c
> index 7bb7232..cc01f7b 100644
> --- a/plugins/ste.c
> +++ b/plugins/ste.c
> @@ -247,7 +247,7 @@ static int ste_enable(struct ofono_modem *modem)
>  		return -EIO;
>  
>  	data->chat = g_at_chat_new_blocking(channel, syntax);
> -	g_at_chat_send(data->chat, "AT&F E0 V1 X4 &C1 +CMEE=1",
> +	g_at_chat_send(data->chat, "AT&F E0 V1 X4 &C1 +CMEE=1;+CSCS=\"UTF-8\"",
>  			NULL, NULL, NULL, NULL);

is it guaranteed that every single STE modem supports UTF-8 character
set?

I would rather see a new command checking for supported character sets
and then picking the default. And intermixing with ATE is not really
clean from my perspective.

Regards

Marcel

Re: [PATCH] ste: Use UTF-8 as a default character set

[Lasse Kunnasluoto]

[-- Attachment #1: Type: text/plain, Size: 1547 bytes --]

Hi Marcel,

On Tue, 2011-01-18 at 16:32 +0200, Marcel Holtmann wrote:
> Hi Lasse,
> 
> >  plugins/ste.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/plugins/ste.c b/plugins/ste.c
> > index 7bb7232..cc01f7b 100644
> > --- a/plugins/ste.c
> > +++ b/plugins/ste.c
> > @@ -247,7 +247,7 @@ static int ste_enable(struct ofono_modem *modem)
> >  		return -EIO;
> >  
> >  	data->chat = g_at_chat_new_blocking(channel, syntax);
> > -	g_at_chat_send(data->chat, "AT&F E0 V1 X4 &C1 +CMEE=1",
> > +	g_at_chat_send(data->chat, "AT&F E0 V1 X4 &C1 +CMEE=1;+CSCS=\"UTF-8\"",
> >  			NULL, NULL, NULL, NULL);
> 
> is it guaranteed that every single STE modem supports UTF-8 character
> set?
> 
Based on information I have, yes, every single ste modem support UTF-8.

> I would rather see a new command checking for supported character sets
> and then picking the default. And intermixing with ATE is not really
> clean from my perspective.
You want this to be changed accordingly? I tried to to follow minimalism
in this simple change and not to introduce new functions. If command
fails for some reason, modem uses its default value, which is IRA. It
could be on a separate line, but still I would not add a call back for
it, nothing to do if the command fails. I prefer the patch I sent, but
you can decide 

> 
> Regards
> 
> Marcel
> 
> 
> _______________________________________________
> ofono mailing list
> ofono(a)ofono.org
> http://lists.ofono.org/listinfo/ofono

Re: [PATCH] ste: Use UTF-8 as a default character set

[Marcel Holtmann]

[-- Attachment #1: Type: text/plain, Size: 1062 bytes --]

Hi Laase,

> > is it guaranteed that every single STE modem supports UTF-8 character
> > set?
> > 
> Based on information I have, yes, every single ste modem support UTF-8.
> 
> > I would rather see a new command checking for supported character sets
> > and then picking the default. And intermixing with ATE is not really
> > clean from my perspective.
> You want this to be changed accordingly? I tried to to follow minimalism
> in this simple change and not to introduce new functions. If command
> fails for some reason, modem uses its default value, which is IRA. It
> could be on a separate line, but still I would not add a call back for
> it, nothing to do if the command fails. I prefer the patch I sent, but
> you can decide 

so at least use AT+CSCS=\"UTF-8\" as a separate command after the init
command and put a comment above that all STE modems support UTF-8.

And to answer your question, I have seen other modems misbehaving when
it comes to charsets and even lying to use. That is why I asked ;)

Regards

Marcel