* [PATCH] atmodem: fix signal strength issue with ifx
@ 2011-01-18 15:00 Jeevaka Badrappan
2011-01-18 15:05 ` Marcel Holtmann
0 siblings, 1 reply; 2+ messages in thread
From: Jeevaka Badrappan @ 2011-01-18 15:00 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 753 bytes --]
---
drivers/atmodem/network-registration.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/atmodem/network-registration.c b/drivers/atmodem/network-registration.c
index 0c77ba8..e11c974 100644
--- a/drivers/atmodem/network-registration.c
+++ b/drivers/atmodem/network-registration.c
@@ -662,13 +662,13 @@ static void ifx_xciev_notify(GAtResult *result, gpointer user_data)
return;
if (ind == 0)
- strength = 0;
+ strength = -1;
else if (ind == 7)
strength = 100;
else
strength = (ind * 15);
- ofono_netreg_strength_notify(netreg, ind);
+ ofono_netreg_strength_notify(netreg, strength);
}
static void ciev_notify(GAtResult *result, gpointer user_data)
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] atmodem: fix signal strength issue with ifx
2011-01-18 15:00 [PATCH] atmodem: fix signal strength issue with ifx Jeevaka Badrappan
@ 2011-01-18 15:05 ` Marcel Holtmann
0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2011-01-18 15:05 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 809 bytes --]
Hi Jeevaka,
> drivers/atmodem/network-registration.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/atmodem/network-registration.c b/drivers/atmodem/network-registration.c
> index 0c77ba8..e11c974 100644
> --- a/drivers/atmodem/network-registration.c
> +++ b/drivers/atmodem/network-registration.c
> @@ -662,13 +662,13 @@ static void ifx_xciev_notify(GAtResult *result, gpointer user_data)
> return;
>
> if (ind == 0)
> - strength = 0;
> + strength = -1;
> else if (ind == 7)
> strength = 100;
> else
> strength = (ind * 15);
>
> - ofono_netreg_strength_notify(netreg, ind);
> + ofono_netreg_strength_notify(netreg, strength);
good catch. I really screwed this one up. Patch has been applied.
Regards
Marcel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-18 15:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-18 15:00 [PATCH] atmodem: fix signal strength issue with ifx Jeevaka Badrappan
2011-01-18 15:05 ` Marcel Holtmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.