All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Galbraith <efault@gmx.de>
To: Yong Zhang <yong.zhang0@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	samu.p.onkalo@nokia.com, mingo@elte.hu,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	tglx <tglx@linutronix.de>
Subject: Re: Bug in scheduler when using rt_mutex
Date: Wed, 19 Jan 2011 06:40:57 +0100	[thread overview]
Message-ID: <1295415657.8017.113.camel@marge.simson.net> (raw)
In-Reply-To: <AANLkTineieNdiKduDHQ-J+Xv6Pq9O0pTZraBJEw=p5e7@mail.gmail.com>

On Wed, 2011-01-19 at 12:35 +0800, Yong Zhang wrote:

> cfs_rq->curr != se is always true.

If that were always true, we'd illegally enqueue a running task.

        if (running)
                p->sched_class->set_curr_task(rq);
                ==> set_curr_task_fair(rq);
                ==>      struct sched_entity *se = &rq->curr->se;
                ==>      set_next_entity(cfs_rq_of(se), se);
                ==>          cfs_rq->curr = se;
                (prevents running entity from being enqueued below)
        if (on_rq) {
                enqueue_task(rq, p, oldprio < prio ? ENQUEUE_HEAD : 0);

                check_class_changed(rq, p, prev_class, oldprio, running);
        }

	-Mike


  reply	other threads:[~2011-01-19  5:41 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-17 14:42 Bug in scheduler when using rt_mutex Onkalo Samu
2011-01-17 15:00 ` Peter Zijlstra
2011-01-17 15:15   ` samu.p.onkalo
2011-01-17 15:28     ` Peter Zijlstra
2011-01-17 16:00 ` Peter Zijlstra
2011-01-18  8:23   ` Onkalo Samu
2011-01-18  8:59     ` Yong Zhang
2011-01-18 13:35       ` Peter Zijlstra
2011-01-18 14:25         ` Onkalo Samu
2011-01-19  2:38         ` Yong Zhang
2011-01-19  3:43           ` Mike Galbraith
2011-01-19  4:35             ` Yong Zhang
2011-01-19  5:40               ` Mike Galbraith [this message]
2011-01-19  6:09                 ` Yong Zhang
2011-01-19  6:37                   ` Mike Galbraith
2011-01-19  7:19                     ` Ingo Molnar
2011-01-19  7:41                       ` Mike Galbraith
2011-01-19  9:44           ` Peter Zijlstra
2011-01-19 10:38             ` Peter Zijlstra
2011-01-19 11:30               ` Peter Zijlstra
2011-01-19 12:58                 ` Onkalo Samu
2011-01-19 13:13                   ` Onkalo Samu
2011-01-19 13:30                     ` Peter Zijlstra
2011-01-20  4:18                       ` Yong Zhang
2011-01-20  4:27                         ` Yong Zhang
2011-01-20  5:32                           ` Yong Zhang
2011-01-20  4:59                         ` Mike Galbraith
2011-01-20  5:30                           ` Yong Zhang
2011-01-20  6:12                             ` Mike Galbraith
2011-01-20  7:06                               ` Yong Zhang
2011-01-20  8:37                                 ` Mike Galbraith
2011-01-20  9:07                                   ` Yong Zhang
2011-01-20 10:07                                     ` Mike Galbraith
2011-01-21 11:08                                       ` Peter Zijlstra
2011-01-21 12:24                                         ` Yong Zhang
2011-01-21 13:40                                           ` Peter Zijlstra
2011-01-21 15:03                                             ` Yong Zhang
2011-01-21 15:10                                               ` Peter Zijlstra
2011-01-21 13:15                                       ` Yong Zhang
2011-01-20  7:07                       ` Onkalo Samu
2011-01-21  6:25                         ` Onkalo Samu
2011-01-20  3:10             ` Yong Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1295415657.8017.113.camel@marge.simson.net \
    --to=efault@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=samu.p.onkalo@nokia.com \
    --cc=tglx@linutronix.de \
    --cc=yong.zhang0@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.