[PATCH][2.6.34 KERNEL] wrs_meta: turn on OHCI USB config option

[PATCH][2.6.34 KERNEL] wrs_meta: turn on OHCI USB config option

[Tom Zanussi]

Allow crownbay to recognize low-speed devices such as mouse and
keyboard.

Pull URL: git://git.pokylinux.org/linux-2.6-windriver-contrib.git
  Branch: tzanussi/crownbay-usb-fix
  Browse:
http://git.pokylinux.org/cgit.cgi/linux-2.6-windriver-contrib/log/?h=tzanussi/crownbay-usb-fix

Please pull...

Thanks,
    Tom Zanussi <tom.zanussi@intel.com>

Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
---
 wrs/cfg/kernel-cache/bsp/crownbay/crownbay.cfg |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/wrs/cfg/kernel-cache/bsp/crownbay/crownbay.cfg b/wrs/cfg/kernel-cache/bsp/crownbay/crownbay.cfg
index a516dc9..864e1dc 100644
--- a/wrs/cfg/kernel-cache/bsp/crownbay/crownbay.cfg
+++ b/wrs/cfg/kernel-cache/bsp/crownbay/crownbay.cfg
@@ -21,6 +21,7 @@ CONFIG_USB_EHCI_HCD=y
 CONFIG_PCIEPORTBUS=y
 CONFIG_NET=y
 CONFIG_USB_UHCI_HCD=y
+CONFIG_USB_OHCI_HCD=y
 CONFIG_BLK_DEV_SD=y
 CONFIG_CHR_DEV_SG=y
 CONFIG_SOUND=y
-- 
1.7.0.4

Re: [PATCH][2.6.34 KERNEL] wrs_meta: turn on OHCI USB config option

[Darren Hart]

On 01/20/2011 10:00 AM, Tom Zanussi wrote:
> Allow crownbay to recognize low-speed devices such as mouse and
> keyboard.
>
> Pull URL: git://git.pokylinux.org/linux-2.6-windriver-contrib.git
>    Branch: tzanussi/crownbay-usb-fix
>    Browse:
> http://git.pokylinux.org/cgit.cgi/linux-2.6-windriver-contrib/log/?h=tzanussi/crownbay-usb-fix
>
> Please pull...
>
> Thanks,
>      Tom Zanussi<tom.zanussi@intel.com>
>
> Signed-off-by: Tom Zanussi<tom.zanussi@intel.com>
> ---
>   wrs/cfg/kernel-cache/bsp/crownbay/crownbay.cfg |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/wrs/cfg/kernel-cache/bsp/crownbay/crownbay.cfg b/wrs/cfg/kernel-cache/bsp/crownbay/crownbay.cfg
> index a516dc9..864e1dc 100644
> --- a/wrs/cfg/kernel-cache/bsp/crownbay/crownbay.cfg
> +++ b/wrs/cfg/kernel-cache/bsp/crownbay/crownbay.cfg
> @@ -21,6 +21,7 @@ CONFIG_USB_EHCI_HCD=y
>   CONFIG_PCIEPORTBUS=y
>   CONFIG_NET=y
>   CONFIG_USB_UHCI_HCD=y
> +CONFIG_USB_OHCI_HCD=y
>   CONFIG_BLK_DEV_SD=y
>   CONFIG_CHR_DEV_SG=y
>   CONFIG_SOUND=y

This seems like the sort of thing we should push to standard. Or do BSPs 
like the crownbay start from an empty config?

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel

Re: [PATCH][2.6.34 KERNEL] wrs_meta: turn on OHCI USB config option

[Tom Zanussi]

On Thu, 2011-01-20 at 10:28 -0800, Darren Hart wrote:
> On 01/20/2011 10:00 AM, Tom Zanussi wrote:
> > Allow crownbay to recognize low-speed devices such as mouse and
> > keyboard.
> >
> > Pull URL: git://git.pokylinux.org/linux-2.6-windriver-contrib.git
> >    Branch: tzanussi/crownbay-usb-fix
> >    Browse:
> > http://git.pokylinux.org/cgit.cgi/linux-2.6-windriver-contrib/log/?h=tzanussi/crownbay-usb-fix
> >
> > Please pull...
> >
> > Thanks,
> >      Tom Zanussi<tom.zanussi@intel.com>
> >
> > Signed-off-by: Tom Zanussi<tom.zanussi@intel.com>
> > ---
> >   wrs/cfg/kernel-cache/bsp/crownbay/crownbay.cfg |    1 +
> >   1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/wrs/cfg/kernel-cache/bsp/crownbay/crownbay.cfg b/wrs/cfg/kernel-cache/bsp/crownbay/crownbay.cfg
> > index a516dc9..864e1dc 100644
> > --- a/wrs/cfg/kernel-cache/bsp/crownbay/crownbay.cfg
> > +++ b/wrs/cfg/kernel-cache/bsp/crownbay/crownbay.cfg
> > @@ -21,6 +21,7 @@ CONFIG_USB_EHCI_HCD=y
> >   CONFIG_PCIEPORTBUS=y
> >   CONFIG_NET=y
> >   CONFIG_USB_UHCI_HCD=y
> > +CONFIG_USB_OHCI_HCD=y
> >   CONFIG_BLK_DEV_SD=y
> >   CONFIG_CHR_DEV_SG=y
> >   CONFIG_SOUND=y
> 
> This seems like the sort of thing we should push to standard. Or do BSPs 
> like the crownbay start from an empty config?
> 

Yeah, I remember awhile back discussing that we wanted to factor the
things in the base configs out into e.g. standard, which of course would
still be a good thing to do.

But for now, I went with the existing flow and put it alongside other
similar options in that BSP...

Tom

Re: [PATCH][2.6.34 KERNEL] wrs_meta: turn on OHCI USB config option

[Bruce Ashfield]

On Thu, Jan 20, 2011 at 1:38 PM, Tom Zanussi <tom.zanussi@intel.com> wrote:
> On Thu, 2011-01-20 at 10:28 -0800, Darren Hart wrote:
>> On 01/20/2011 10:00 AM, Tom Zanussi wrote:
>> > Allow crownbay to recognize low-speed devices such as mouse and
>> > keyboard.
>> >
>> > Pull URL: git://git.pokylinux.org/linux-2.6-windriver-contrib.git
>> >    Branch: tzanussi/crownbay-usb-fix
>> >    Browse:
>> > http://git.pokylinux.org/cgit.cgi/linux-2.6-windriver-contrib/log/?h=tzanussi/crownbay-usb-fix
>> >
>> > Please pull...
>> >
>> > Thanks,
>> >      Tom Zanussi<tom.zanussi@intel.com>
>> >
>> > Signed-off-by: Tom Zanussi<tom.zanussi@intel.com>
>> > ---
>> >   wrs/cfg/kernel-cache/bsp/crownbay/crownbay.cfg |    1 +
>> >   1 files changed, 1 insertions(+), 0 deletions(-)
>> >
>> > diff --git a/wrs/cfg/kernel-cache/bsp/crownbay/crownbay.cfg b/wrs/cfg/kernel-cache/bsp/crownbay/crownbay.cfg
>> > index a516dc9..864e1dc 100644
>> > --- a/wrs/cfg/kernel-cache/bsp/crownbay/crownbay.cfg
>> > +++ b/wrs/cfg/kernel-cache/bsp/crownbay/crownbay.cfg
>> > @@ -21,6 +21,7 @@ CONFIG_USB_EHCI_HCD=y
>> >   CONFIG_PCIEPORTBUS=y
>> >   CONFIG_NET=y
>> >   CONFIG_USB_UHCI_HCD=y
>> > +CONFIG_USB_OHCI_HCD=y
>> >   CONFIG_BLK_DEV_SD=y
>> >   CONFIG_CHR_DEV_SG=y
>> >   CONFIG_SOUND=y
>>
>> This seems like the sort of thing we should push to standard. Or do BSPs
>> like the crownbay start from an empty config?
>>
>
> Yeah, I remember awhile back discussing that we wanted to factor the
> things in the base configs out into e.g. standard, which of course would
> still be a good thing to do.

Agreed.

>
> But for now, I went with the existing flow and put it alongside other
> similar options in that BSP...

Also fine for now, but having a "usb" config that we could just
include and push out to all BSPs, makes adding a sane set of
options much easier.

As to pushing it down. Can anyone think of side effects of this
on boards that don't have the hardware ? i.e. slower boot, devices
detected in the slower format, or anything like that ? If there
aren't any side effects, and we agree that increasing the base
config (which should be as small/lean as possible) size a bit is fine,
then we can absolutely push it down and at the flick of a switch
enable all supported BSPs with the functionality.

Cheers,

Bruce

>
> Tom
>
>
>



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"