All of lore.kernel.org
 help / color / mirror / Atom feed
From: Axel Lin <axel.lin@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Lennert Buytenhek <buytenh@marvell.com>,
	Green Wan <gwan@marvell.com>, Eric Miao <eric.y.miao@gmail.com>,
	Marek Vasut <marek.vasut@gmail.com>,
	Haojian Zhuang <haojian.zhuang@marvell.com>,
	linux-fbdev@vger.kernel.org,
	Paul Mundt <lethal@linux-sh.org>Lennert Buytenhek
	<buytenh@marvell.com>Green Wan <gwan@marvell.com>Eric Miao
	<eric.y.miao@gmail.com>Marek Vasut
	<marek.vasut@gmail.com>Haojian Zhuang
	<haojian.zhuang@marvell.com>linux-fbdev@vger.kernel.orgPaul
	Mundt <lethal@linux-sh.org>
Subject: [PATCH] video: pxa168fb: remove a redundant pxa168fb_check_var call
Date: Fri, 21 Jan 2011 11:18:06 +0000	[thread overview]
Message-ID: <1295608686.3976.9.camel@phoenix> (raw)

Current implementation calls pxa168fb_check_var twice in pxa168fb_probe.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 drivers/video/pxa168fb.c |    6 +-----
 1 files changed, 1 insertions(+), 5 deletions(-)

diff --git a/drivers/video/pxa168fb.c b/drivers/video/pxa168fb.c
index cea6403..35f61dd 100644
--- a/drivers/video/pxa168fb.c
+++ b/drivers/video/pxa168fb.c
@@ -701,16 +701,12 @@ static int __devinit pxa168fb_probe(struct platform_device *pdev)
 	 */
 	pxa168fb_init_mode(info, mi);
 
-	ret = pxa168fb_check_var(&info->var, info);
-	if (ret)
-		goto failed_free_fbmem;
-
 	/*
 	 * Fill in sane defaults.
 	 */
 	ret = pxa168fb_check_var(&info->var, info);
 	if (ret)
-		goto failed;
+		goto failed_free_fbmem;
 
 	/*
 	 * enable controller clock
-- 
1.7.0.4




WARNING: multiple messages have this Message-ID (diff)
From: Axel Lin <axel.lin@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Lennert Buytenhek <buytenh@marvell.com>,
	Green Wan <gwan@marvell.com>, Eric Miao <eric.y.miao@gmail.com>,
	Marek Vasut <marek.vasut@gmail.com>,
	Haojian Zhuang <haojian.zhuang@marvell.com>,
	linux-fbdev@vger.kernel.org, Paul Mundt <lethal@linux-sh.org>,
	Lennert Buytenhek <buytenh@marvell.com>,
	Green Wan <gwan@marvell.com>, Eric Miao <eric.y.miao@gmail.com>,
	Marek Vasut <marek.vasut@gmail.com>,
	Haojian Zhuang <haojian.zhuang@marvell.com>,
	linux-fbdev@vger.kernel.org, Paul Mundt <lethal@linux-sh.org>
Subject: [PATCH] video: pxa168fb: remove a redundant pxa168fb_check_var call
Date: Fri, 21 Jan 2011 19:18:06 +0800	[thread overview]
Message-ID: <1295608686.3976.9.camel@phoenix> (raw)

Current implementation calls pxa168fb_check_var twice in pxa168fb_probe.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 drivers/video/pxa168fb.c |    6 +-----
 1 files changed, 1 insertions(+), 5 deletions(-)

diff --git a/drivers/video/pxa168fb.c b/drivers/video/pxa168fb.c
index cea6403..35f61dd 100644
--- a/drivers/video/pxa168fb.c
+++ b/drivers/video/pxa168fb.c
@@ -701,16 +701,12 @@ static int __devinit pxa168fb_probe(struct platform_device *pdev)
 	 */
 	pxa168fb_init_mode(info, mi);
 
-	ret = pxa168fb_check_var(&info->var, info);
-	if (ret)
-		goto failed_free_fbmem;
-
 	/*
 	 * Fill in sane defaults.
 	 */
 	ret = pxa168fb_check_var(&info->var, info);
 	if (ret)
-		goto failed;
+		goto failed_free_fbmem;
 
 	/*
 	 * enable controller clock
-- 
1.7.0.4




             reply	other threads:[~2011-01-21 11:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-21 11:18 Axel Lin [this message]
2011-01-21 11:18 ` [PATCH] video: pxa168fb: remove a redundant pxa168fb_check_var call Axel Lin
2011-01-20  3:50 ` [PATCH] video: da8xx-fb: fix fb_probe error path Axel Lin
2011-01-20  3:50   ` Axel Lin
2011-01-25  6:11   ` Paul Mundt
2011-01-25  6:11     ` Paul Mundt
2011-01-21 18:07 ` [PATCH] video: pxa168fb: remove a redundant pxa168fb_check_var call Marek Vasut
2011-01-21 18:07   ` Marek Vasut
2011-01-21 18:33   ` Mark Brown
2011-01-21 18:33     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1295608686.3976.9.camel@phoenix \
    --to=axel.lin@gmail.com \
    --cc=buytenh@marvell.com \
    --cc=eric.y.miao@gmail.com \
    --cc=gwan@marvell.com \
    --cc=haojian.zhuang@marvell.com \
    --cc=lethal@linux-sh.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marek.vasut@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.