From: Artem Bityutskiy <dedekind1@gmail.com>
To: John Ogness <john.ogness@linutronix.de>
Cc: linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] UBI: fix unaligned leb_start value
Date: Tue, 25 Jan 2011 12:42:40 +0200 [thread overview]
Message-ID: <1295952160.7118.1.camel@localhost> (raw)
In-Reply-To: <87zkqu1fuh.fsf@vostro.fn.ogness.net>
On Fri, 2011-01-21 at 15:39 +0100, John Ogness wrote:
> From: John Ogness <john.ogness@linutronix.de>
>
> The wrong header size was used in calculating the data offset. The
> data offset should be VID header offset + VID header size (aligned to
> the minimum I/O unit).
>
> Signed-off-by: John Ogness <john.ogness@linutronix.de>
I've tweaked the commit message and pushed this to the UBI tree, thanks:
http://git.infradead.org/ubi-2.6.git/commit/a25376636fa6cee8017a22144652f276840281bf
> ---
> This patch is against linux-next-20110121.
>
> Since the value is later aligned, this patch does not fix any real
> world problem. But it should be fixed nonetheless.
Not exactly, this does not fix any real problem because UBI_EC_HDR_SIZE
and UBI_VID_HDR_SIZE are currently equivalent :-)
Thank you!
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind1@gmail.com>
To: John Ogness <john.ogness@linutronix.de>
Cc: David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] UBI: fix unaligned leb_start value
Date: Tue, 25 Jan 2011 12:42:40 +0200 [thread overview]
Message-ID: <1295952160.7118.1.camel@localhost> (raw)
In-Reply-To: <87zkqu1fuh.fsf@vostro.fn.ogness.net>
On Fri, 2011-01-21 at 15:39 +0100, John Ogness wrote:
> From: John Ogness <john.ogness@linutronix.de>
>
> The wrong header size was used in calculating the data offset. The
> data offset should be VID header offset + VID header size (aligned to
> the minimum I/O unit).
>
> Signed-off-by: John Ogness <john.ogness@linutronix.de>
I've tweaked the commit message and pushed this to the UBI tree, thanks:
http://git.infradead.org/ubi-2.6.git/commit/a25376636fa6cee8017a22144652f276840281bf
> ---
> This patch is against linux-next-20110121.
>
> Since the value is later aligned, this patch does not fix any real
> world problem. But it should be fixed nonetheless.
Not exactly, this does not fix any real problem because UBI_EC_HDR_SIZE
and UBI_VID_HDR_SIZE are currently equivalent :-)
Thank you!
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2011-01-25 10:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-21 14:39 [PATCH] UBI: fix unaligned leb_start value John Ogness
2011-01-21 14:39 ` John Ogness
2011-01-25 10:42 ` Artem Bityutskiy [this message]
2011-01-25 10:42 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295952160.7118.1.camel@localhost \
--to=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.